Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37319: Deprecated support of non-integer arguments in random.randrange(). #19112

Merged
merged 10 commits into from Jan 25, 2021
Merged

bpo-37319: Deprecated support of non-integer arguments in random.randrange(). #19112

merged 10 commits into from Jan 25, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 22, 2020 •
edited by bedevere-bot

@rhettinger
Copy link
Contributor

rhettinger commented Mar 22, 2020

I don't think this should be done. It churns an API that has been stable for two decades. It doesn't solve a real problem. It may break working code. It makes the code look gross. It will complicate maintenance.

rhettinger
rhettinger reviewed Mar 22, 2020
View changes
Lib/random.py Outdated Show resolved Hide resolved
@alimcmaster1
Copy link

alimcmaster1 commented Apr 11, 2020

Looks like this is good to close from the discussion on https://bugs.python.org/issue37319 ?

@serhiy-storchaka serhiy-storchaka deleted the randrange-index branch Apr 11, 2020
@serhiy-storchaka serhiy-storchaka restored the randrange-index branch Oct 31, 2020
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Oct 31, 2020

Reopened because @rhettinger just opened a duplicate issue.

According to the same microbenchmark as in #23064, this PR provides a 10% speed up:

$ ./python -m timeit -s 'from random import randrange' 'randrange(15)' # baseline
500000 loops, best of 5: 515 nsec per loop
$ ./python -m timeit -s 'from random import randrange' 'randrange(15)'  # new version
500000 loops, best of 5: 467 nsec per loop

rhettinger
rhettinger reviewed Oct 31, 2020
View changes
Lib/random.py
except TypeError:
istep = int(step)
if istep != step:
raise ValueError("non-integer step for randrange()")
Copy link
Contributor

@rhettinger rhettinger Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, the exception type should be converted to TypeError.

Copy link
Member Author

@serhiy-storchaka serhiy-storchaka Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we raise it with custom message or reraise the exception raised by index()?

@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 24, 2020
Merged
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Dec 24, 2020

@rhettinger, what are your problems with this PR? I addressed your comments, and would appreciate any other suggestions.

@rhettinger
Copy link
Contributor

rhettinger commented Dec 28, 2020

I merged in PR 23064. If you want to make further modifications or improvements that would be welcome.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Dec 29, 2020

I merged with master. Please make review.

@serhiy-storchaka serhiy-storchaka merged commit f066bd9 into python:master Jan 25, 2021
3 checks passed
@serhiy-storchaka serhiy-storchaka deleted the randrange-index branch Jan 25, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@serhiy-storchaka @adorilson
bpo-37319: Improve documentation, code and tests of randrange. (pytho…
042869c 
…nGH-19112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

@mdickinson mdickinson

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serhiy-storchaka @rhettinger @alimcmaster1 @nenell12211 @the-knights-who-say-ni @bedevere-bot