Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-89237: fix hang in proactor subprocess.wait_closed() #98572

Merged
merged 4 commits into from Oct 24, 2022
Merged

GH-89237: fix hang in proactor subprocess.wait_closed() #98572

merged 4 commits into from Oct 24, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 23, 2022 •
edited by bedevere-bot

@kumaraditya303 kumaraditya303 mentioned this pull request Oct 23, 2022
Closed
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 23, 2022
Closed
@kumaraditya303 kumaraditya303 marked this pull request as ready for review Oct 23, 2022
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 24, 2022
@bedevere-bot
Copy link

bedevere-bot commented Oct 24, 2022

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 008be56 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 24, 2022
@gvanrossum gvanrossum merged commit ad1dc3e into python:main Oct 24, 2022
15 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 24, 2022

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 24, 2022

GH-98620 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@kumaraditya303 @miss-islington
pythonGH-89237: fix hang in proactor subprocess.wait_closed() (pyth…
018776c 
…onGH-98572)

(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 24, 2022

GH-98621 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@kumaraditya303 @miss-islington
pythonGH-89237: fix hang in proactor subprocess.wait_closed() (pyth…
78ca5ae 
…onGH-98572)

(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @kumaraditya303
GH-89237: fix hang in proactor subprocess.wait_closed() (GH-98572)
8ba086f 
(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
gvanrossum pushed a commit that referenced this pull request Oct 25, 2022
@miss-islington @kumaraditya303
[3.11] GH-89237: fix hang in proactor subprocess.wait_closed() (GH-…
8950689 
…98572) (#98620)

GH-89237: fix hang in proactor `subprocess.wait_closed()` (GH-98572)
(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 deleted the subprocess-asyncio-block branch Oct 25, 2022
@Fidget-Spinner Fidget-Spinner mentioned this pull request Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
expert-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @bedevere-bot @miss-islington @gvanrossum