Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38110: Use fdwalk for os.closerange() when available. #15224

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@kulikjak
Copy link
Contributor

commented Aug 12, 2019 •
edited by gpshead

Use fdwalk() on platforms that support it to implement os.closerange().

https://bugs.python.org/issue38110
@kulikjak
Add fdwalk functionality
Loading status checks…
3f6ec8d

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 12, 2019

@bedevere-bot bedevere-bot added the awaiting review label Aug 12, 2019

@gpshead gpshead self-requested a review Sep 10, 2019

@gpshead gpshead self-assigned this Sep 10, 2019

@gpshead gpshead added the needs backport to 3.8 label Sep 10, 2019

@gpshead gpshead changed the title Use fdwalk for posix_closerange function. bpo-38110: Use fdwalk for posix_closerange function. Sep 11, 2019

@gpshead
Add NEWS entry.
Loading status checks…
e024cc7
@gpshead
gpshead approved these changes Sep 11, 2019
View changes

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 11, 2019

@gpshead
Use PY_MAX(fd_low, 0) as the existing code does.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f435386

@gpshead gpshead changed the title bpo-38110: Use fdwalk for posix_closerange function. bpo-38110: Use fdwalk for os.closerange() when available. Sep 11, 2019

@gpshead gpshead merged commit e20134f into python:master Sep 11, 2019
4 checks passed

4 checks passed

Azure Pipelines PR #20190911.142 succeeded
Details
bedevere/issue-number Issue number 38110 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

Thanks @kulikjak for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Sep 11, 2019

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@kulikjak @miss-islington
bpo-38110: Use fdwalk for os.closerange() when available. (pythonGH-1… 
…5224)

Use fdwalk() on platforms that support it to implement os.closerange().
(cherry picked from commit e20134f)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
318a9ae

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 11, 2019

@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

GH-15978 is a backport of this pull request to the 3.8 branch.
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
@kulikjak @vrpolakatcisco
bpo-38110: Use fdwalk for os.closerange() when available. (pythonGH-1… 
…5224)

Use fdwalk() on platforms that support it to implement os.closerange().
89c2ee3
miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @kulikjak
bpo-38110: Use fdwalk for os.closerange() when available. (GH-15224) 
Use fdwalk() on platforms that support it to implement os.closerange().
(cherry picked from commit e20134f)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
84eb42e
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@kulikjak @DinoV
bpo-38110: Use fdwalk for os.closerange() when available. (pythonGH-1… 
…5224)

Use fdwalk() on platforms that support it to implement os.closerange().
93a8380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@gpshead gpshead

Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@kulikjak @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni
You can’t perform that action at this time.