Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-38110: Use fdwalk for os.closerange() when available. (GH-15224) #15978

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@miss-islington
Copy link

commented Sep 11, 2019 •
edited by bedevere-bot

Use fdwalk() on platforms that support it to implement os.closerange().
(cherry picked from commit e20134f)

Co-authored-by: Jakub Kulík Kulikjak@gmail.com

https://bugs.python.org/issue38110
@kulikjak @miss-islington
bpo-38110: Use fdwalk for os.closerange() when available. (GH-15224) 
Use fdwalk() on platforms that support it to implement os.closerange().
(cherry picked from commit e20134f)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
Loading status checks…
318a9ae

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 11, 2019

@bedevere-bot bedevere-bot referenced this pull request Sep 11, 2019
Merged

@bedevere-bot bedevere-bot added the awaiting review label Sep 11, 2019

@gpshead

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 11, 2019

I'm going to let the buildbots run on master as a sanity check before approving this.

@gpshead gpshead self-assigned this Sep 11, 2019

@gpshead gpshead added the DO-NOT-MERGE label Sep 11, 2019

@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

commented Sep 11, 2019

@kulikjak and @gpshead: Status check is done, and it's a success ✅ .
2 similar comments
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

commented Sep 11, 2019

@kulikjak and @gpshead: Status check is done, and it's a success ✅ .
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

commented Sep 11, 2019

@kulikjak and @gpshead: Status check is done, and it's a success ✅ .

@gpshead gpshead removed the DO-NOT-MERGE label Sep 12, 2019

@gpshead
gpshead approved these changes Sep 12, 2019
View changes

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 12, 2019

@miss-islington miss-islington merged commit 84eb42e into python:3.8 Sep 12, 2019
5 checks passed

5 checks passed

Azure Pipelines PR #20190911.181 succeeded
Details
bedevere/issue-number Issue number 38110 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miss-islington miss-islington deleted the miss-islington:backport-e20134f-3.8 branch Sep 12, 2019

@bedevere-bot bedevere-bot removed the awaiting merge label Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@gpshead gpshead

Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot @kulikjak
You can’t perform that action at this time.