Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in a comment in dataclasses.py. #25454

Merged
merged 1 commit into from Apr 17, 2021
Merged

Fix typo in a comment in dataclasses.py. #25454

merged 1 commit into from Apr 17, 2021

Conversation

ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Apr 17, 2021 •
edited by miss-islington

No description provided.

@ericvsmith ericvsmith self-assigned this Apr 17, 2021
@ericvsmith ericvsmith added 🤖 automerge PR will be merged once it's been approved and all CI passed needs backport to 3.8 needs backport to 3.9 skip issue skip news and removed 🤖 automerge PR will be merged once it's been approved and all CI passed labels Apr 17, 2021
@ericvsmith ericvsmith merged commit 76beadb into python:master Apr 17, 2021
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 17, 2021

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2021
@ericvsmith @miss-islington
Fix typo in a dataclasses comment. (pythonGH-25454)
8d6b738 
(cherry picked from commit 76beadb)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2021

GH-25456 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2021
@ericvsmith @miss-islington
Fix typo in a dataclasses comment. (pythonGH-25454)
f758496 
(cherry picked from commit 76beadb)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2021

GH-25457 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Apr 17, 2021
@miss-islington @ericvsmith
Fix typo in a dataclasses comment. (GH-25454)
303ffb7 
(cherry picked from commit 76beadb)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 17, 2021
@miss-islington @ericvsmith
Fix typo in a dataclasses comment. (GH-25454)
0121f67 
(cherry picked from commit 76beadb)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@ericvsmith ericvsmith deleted the fix-comment-typo-dataclasses branch Apr 17, 2021
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@ericvsmith @kreathon
Fix typo in a dataclasses comment. (pythonGH-25454)
f4199b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ericvsmith ericvsmith

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericvsmith @miss-islington @bedevere-bot @the-knights-who-say-ni