Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern syntax in test-case files where possible #9261

Merged
merged 7 commits into from Nov 23, 2022
Merged

Use modern syntax in test-case files where possible #9261

merged 7 commits into from Nov 23, 2022

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Nov 23, 2022

By default, pyupgrade only rewrites .py files, so adding it as a pre-commit hook should have no effect on the stubs/ or stdlib/ directories.

AlexWaygood
AlexWaygood commented Nov 23, 2022
View changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Nov 23, 2022

The stubtest failures in pycurl are unrelated (presumably we'll have a daily test failure this evening).

AlexWaygood added a commit that referenced this pull request Nov 23, 2022
@AlexWaygood
pycurl: Add a few missing constants
b056005 
Fixes the stubtest failure seen in #9261
@AlexWaygood AlexWaygood mentioned this pull request Nov 23, 2022
Merged
hauntsaninja
hauntsaninja reviewed Nov 23, 2022
View changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Not sure we want to run this automatically,e.g. we're changing what we're type checking in the check_post example

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Nov 23, 2022

Not sure we want to run this automatically,e.g. we're changing what we're type checking in the check_post example

Yeah, that's fair.

@AlexWaygood AlexWaygood changed the title Use modern syntax in test-case files where possible; add pyupgrade as a pre-commit hook Use modern syntax in test-case files where possible Nov 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

hauntsaninja
hauntsaninja approved these changes Nov 23, 2022
View changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Looks good!

@hauntsaninja hauntsaninja merged commit 01e78c7 into python:main Nov 23, 2022
61 checks passed
@AlexWaygood AlexWaygood deleted the upgrade-annotations branch Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWaygood @hauntsaninja