Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowsPath does not implement is_mount but ntpath implements and offers a ismount method #86943

Closed
d1b mannequin opened this issue Dec 29, 2020 · 1 comment
Closed

WindowsPath does not implement is_mount but ntpath implements and offers a ismount method #86943

d1b mannequin opened this issue Dec 29, 2020 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@d1b
Copy link
Mannequin

@d1b d1b mannequin commented Dec 29, 2020

BPO 42777
Nosy @barneygale, @d1b
PRs
  • #31458
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-12-29.04:17:59.726>
labels = []
title = 'WindowsPath does not implement is_mount but ntpath implements and offers a ismount method'
updated_at = <Date 2022-02-21.01:48:37.395>
user = 'https://github.com/d1b'

    bugs.python.org fields:

    activity = <Date 2022-02-21.01:48:37.395>
actor = 'barneygale'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2020-12-29.04:17:59.726>
creator = 'db'
dependencies = []
files = []
hgrepos = []
issue_num = 42777
keywords = ['patch']
message_count = 1.0
messages = ['383955']
nosy_count = 2.0
nosy_names = ['barneygale', 'db']
pr_nums = ['31458']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue42777'
versions = []
    @d1b
    Copy link
    Mannequin Author

    @d1b d1b mannequin commented Dec 29, 2020

    pathlib.WindowsPath[0] does not implement is_mount but ntpath implements and offers a ismount[1] method. Perhaps WindowsPath is_mount can make use of ntpath.ismount ?

    [0] https://github.com/python/cpython/blob/master/Lib/pathlib.py#L1578
    [1] https://github.com/python/cpython/blob/master/Lib/ntpath.py#L248

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @AlexWaygood AlexWaygood added the type-feature A feature request or enhancement label Apr 10, 2022
    @barneygale barneygale mentioned this issue Jul 29, 2022
    Draft
    @bedevere-bot bedevere-bot mentioned this issue Jul 30, 2022
    Merged
    miss-islington pushed a commit that referenced this issue Aug 5, 2022
    @barneygale
    gh-86943: implement pathlib.WindowsPath.is_mount() (GH-31458)
    29650fe 
    Have `pathlib.WindowsPath.is_mount()` call `ntpath.ismount()`. Previously it raised `NotImplementedError` unconditionally.


https://bugs.python.org/issue42777
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @AlexWaygood