Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all destructive operations default confirmation to "no" #2878

Closed
ketang opened this issue Jul 10, 2022 · 2 comments · Fixed by #2919
Closed

Make all destructive operations default confirmation to "no" #2878

ketang opened this issue Jul 10, 2022 · 2 comments · Fixed by #2919
Assignees
@AbhineetJain
Labels
good first issue

Comments

@ketang
Copy link
Contributor

@ketang ketang commented Jul 10, 2022

Some destructive operations have their confirmation behavior defaulting to "yes." We should default to "yes" when the behavior is non-destructive, e.g. creating a workspace, but we should default to "no" when it's something destructive, like deleting a user.
@ketang ketang added the good first issue label Jul 10, 2022
@ketang ketang mentioned this issue Jul 10, 2022
Merged
@AbhineetJain AbhineetJain self-assigned this Jul 11, 2022
@AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Jul 11, 2022

Trying to figure out the list of potentially destructive actions we have right now:

  • Deleting a template
  • Deleting a workspace
  • Suspending a user
  • Stopping a workspace
  • Logging out

@ketang Can you confirm if all these actions should default to no? Are there others you have in mind?

@AbhineetJain AbhineetJain mentioned this issue Jul 11, 2022
Merged
3 tasks
@ketang
Copy link
Contributor Author

@ketang ketang commented Jul 11, 2022

I think suspending a user, logging out, and stopping the workspace can default to yes. They're more reversible than the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhineetJain AbhineetJain

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: default confirm to no for safety coder/coder
2 participants
@ketang @AbhineetJain