feat: default confirm to no for safety #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Jul 11, 2022
cli/logout.go
Outdated
| @@ -28,7 +28,7 @@ func logout() *cobra.Command { | |||
| _, err = cliui.Prompt(cmd, cliui.PromptOptions{ | |||
| Text: "Are you sure you want to log out?", | |||
| IsConfirm: true, | |||
| Default: "yes", | |||
| Default: "no", | |||
There was a problem hiding this comment.
Should we make yes/no a constant?
There was a problem hiding this comment.
Yes, sounds like a good idea.
dwahler
reviewed
Jul 11, 2022
| @@ -74,7 +71,7 @@ func createUserStatusCommand(sdkStatus codersdk.UserStatus) *cobra.Command { | |||
| _, err = cliui.Prompt(cmd, cliui.PromptOptions{ | |||
| Text: fmt.Sprintf("Are you sure you want to %s this user?", verb), | |||
| IsConfirm: true, | |||
| Default: defaultConfirm, | |||
| Default: cliui.ConfirmYes, | |||
There was a problem hiding this comment.
Looks like this changes the default back to "yes" when suspending a user, was that intentional?
There was a problem hiding this comment.
Yes, as per the discussion on the issue, the requirements were updated. We want to default to no only in case of deleting templates and workspaces -- the non-reversible kind of deletions.
There was a problem hiding this comment.
Ah, got it, I just missed seeing your edit on the PR description. LGTM!
dwahler
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR sets the default confirmation to
nofor the following cases:Subtasks
Fixes #2878
Screenshot