Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41576: document BaseException in favor of bare except #21917

Merged
merged 7 commits into from Aug 6, 2021
Merged

bpo-41576: document BaseException in favor of bare except #21917

merged 7 commits into from Aug 6, 2021

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Aug 18, 2020 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs awaiting review labels Aug 18, 2020
@graingert graingert changed the title document BaseException in favour of bare except bpo-41576: document BaseException in favour of bare except Aug 18, 2020
graingert
graingert reviewed Aug 18, 2020
View changes
Doc/tutorial/errors.rst Outdated Show resolved Hide resolved
terryjreedy
terryjreedy approved these changes Aug 21, 2020
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

To me, the change improves this section.

graingert
graingert reviewed Aug 21, 2020
View changes
Doc/tutorial/errors.rst Outdated Show resolved Hide resolved
@graingert graingert changed the title bpo-41576: document BaseException in favour of bare except bpo-41576: document BaseException in favor of bare except Aug 21, 2020
graingert
graingert reviewed Aug 22, 2020
View changes
Doc/tutorial/errors.rst Outdated Show resolved Hide resolved
graingert
graingert reviewed Aug 22, 2020
View changes
Doc/tutorial/errors.rst Outdated Show resolved Hide resolved
graingert
graingert reviewed Aug 22, 2020
View changes
Doc/tutorial/errors.rst
@@ -488,5 +489,3 @@ used in a way that ensures they are always cleaned up promptly and correctly. ::
After the statement is executed, the file *f* is always closed, even if a
problem was encountered while processing the lines. Objects which, like files,
provide predefined clean-up actions will indicate this in their documentation.
Copy link
Contributor Author

@graingert graingert Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor keeps trimming this buggy whitespace, so we should probably remove it anyway

@graingert
Copy link
Contributor Author

@graingert graingert commented Sep 12, 2020

@terryjreedy what's the next step here?

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Sep 14, 2020

I am looking at this and will request or make some changes. I need to look at the context and think of how to answer Serhiy's objection on the issue.

@graingert
Copy link
Contributor Author

@graingert graingert commented Jul 5, 2021

@terryjreedy I've now fixed the conflicts in this PR

@graingert graingert requested a review from terryjreedy Jul 20, 2021
@ambv ambv merged commit e9a6f1b into python:main Aug 6, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Sorry, @graingert and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e9a6f1b78bf57d9f3f99547bd007d7cfc9724cfb 3.9

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2021

GH-27646 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2021
@graingert @miss-islington
bpo-41576: document BaseException in favor of bare except (pythonGH-2…
9544854 
…1917)

(cherry picked from commit e9a6f1b)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@graingert graingert deleted the patch-5 branch Aug 6, 2021
miss-islington added a commit that referenced this issue Aug 6, 2021
@miss-islington @graingert
bpo-41576: document BaseException in favor of bare except (GH-21917)
699ee01 
(cherry picked from commit e9a6f1b)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Aug 6, 2021

@ambv Thanks for finishing this.

JuniorJPDJ pushed a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@graingert @JuniorJPDJ
bpo-41576: document BaseException in favor of bare except (pythonGH-2…
4e05188 
…1917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees

@ambv ambv

Labels
CLA signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@graingert @terryjreedy @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni