Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29474: Improve documentation for weakref.WeakValueDictionary #10

Merged
merged 1 commit into from Feb 12, 2017

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 11, 2017

There were some grammatical errors in weakref.WeakValueDictionary
documentation.

This should be applied to 3.5, 3.6, and master.

Original patch was in bpo http://bugs.python.org/file46597/issue29474py3-2.patch

@Mariatta
Copy link
Sponsor Member Author

@Mariatta Mariatta commented Feb 11, 2017

Not sure if I'm doing this right.
Is the idea for me to apply the labels backport to 3.5, and backport to 3.6 ?

@zware
Copy link
Member

@zware zware commented Feb 11, 2017

@Mariatta Yes, as far as I know :)

zware
zware approved these changes Feb 11, 2017
There were some grammatical errors in weakref.WeakValueDictionary
documentation.
@codecov
Copy link

@codecov codecov bot commented Feb 11, 2017

Codecov Report

Merging #10 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
+ Hits       289088   289091       +3     
+ Misses      61860    61857       -3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ffb99...c231d45. Read the comment docs.

@Mariatta Mariatta merged commit 3110a37 into python:master Feb 12, 2017
3 checks passed
@Mariatta Mariatta deleted the bpo-29474 branch Feb 12, 2017
ethanhs added a commit to ethanhs/cpython that referenced this issue Feb 7, 2020
tiran added a commit to tiran/cpython that referenced this issue Nov 18, 2020
Direct leak of 57 byte(s) in 1 object(s) allocated from:

    #0 0x7fa6397cc667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    #1 0x777579 in PyUnicode_New Objects/unicodeobject.c:1459
    #2 0x86aa4e in unicode_decode_utf8 Objects/unicodeobject.c:5129
    #3 0x8b6050 in PyUnicode_DecodeUTF8Stateful Objects/unicodeobject.c:5259
    #4 0x8b6050 in PyUnicode_FromString Objects/unicodeobject.c:2311
    #5 0x8b6050 in PyUnicode_InternFromString Objects/unicodeobject.c:15788
    #6 0x8f1e0b in create_filter Python/_warnings.c:67
    #7 0x8f1e0b in init_filters Python/_warnings.c:95
    #8 0x8f1e0b in _PyWarnings_InitState Python/_warnings.c:123
    python#9 0xa52178 in pycore_init_types Python/pylifecycle.c:704
    python#10 0xa52178 in pycore_interp_init Python/pylifecycle.c:760
    python#11 0xa5eab1 in pyinit_config Python/pylifecycle.c:807
    python#12 0xa5eab1 in pyinit_core Python/pylifecycle.c:970
    python#13 0xa60037 in Py_InitializeFromConfig Python/pylifecycle.c:1155
    python#14 0x47a842 in pymain_init Modules/main.c:66
    python#15 0x4802a2 in pymain_main Modules/main.c:698
    python#16 0x4802a2 in Py_BytesMain Modules/main.c:731
    python#17 0x7fa638a5b041 in __libc_start_main (/lib64/libc.so.6+0x27041)

Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants