Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40246: Report a different error message for invalid string prefixes #19476

Merged
merged 2 commits into from Apr 12, 2020
Merged

bpo-40246: Report a different error message for invalid string prefixes #19476

merged 2 commits into from Apr 12, 2020

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Apr 11, 2020 •
edited by bedevere-bot

@lysnikolaou
Copy link
Author

@lysnikolaou lysnikolaou commented Apr 11, 2020

CC: @pablogsal @gvanrossum

gvanrossum
gvanrossum approved these changes Apr 12, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

LGTM. One other core dev please?

pablogsal
pablogsal approved these changes Apr 12, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

@pablogsal pablogsal merged commit 41d5b94 into python:master Apr 12, 2020
9 checks passed
@pablogsal
Copy link

@pablogsal pablogsal commented Apr 12, 2020

Great job @lysnikolaou 🎉

@lysnikolaou lysnikolaou mentioned this pull request Apr 12, 2020
Closed
@lysnikolaou lysnikolaou mentioned this pull request May 3, 2020
Merged
@lysnikolaou lysnikolaou deleted the string-prefix branch May 8, 2020
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
@lysnikolaou @vegerot
bpo-40246: Report a better error message for invalid string prefixes (p…
b07471f 
…ythonGH-19476)
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
@lysnikolaou @vegerot
bpo-40246: Report a better error message for invalid string prefixes (p…
58058be 
…ythonGH-19476)
gmelikov pushed a commit to gmelikov/cpython that referenced this issue Aug 22, 2020
@lysnikolaou @gmelikov
bpo-40246: Report a better error message for invalid string prefixes (p…
323b49b 
…ythonGH-19476)
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@lysnikolaou @chrisburr
bpo-40246: Report a better error message for invalid string prefixes (p…
c9cacaa 
…ythonGH-19476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lysnikolaou @pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot