Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): pass correct arguments to http_server in Windows #30346

Closed
wants to merge 1 commit into from
Closed

fix(bazel): pass correct arguments to http_server in Windows #30346

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented May 9, 2019 •
edited

Under Windows, the server binary has an extension of .exe and the current logic is not handling that.

Partially addresses: #29785

@alan-agius4 alan-agius4 requested review from as code owners May 9, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 9, 2019
@alan-agius4
fix(bazel): pass correct arguments to http_server in Windows
c3db1eb 
Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: angular#29785
kyliau
kyliau approved these changes May 9, 2019
View changes
alxhub added a commit that referenced this issue May 9, 2019
@alan-agius4 @alxhub
fix(bazel): pass correct arguments to http_server in Windows (#30346)
71eba45 
Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: #29785

PR Close #30346
BioPhoton added a commit to BioPhoton/angular that referenced this issue May 21, 2019
@alan-agius4 @BioPhoton
fix(bazel): pass correct arguments to http_server in Windows (angular…
9403baa 
…#30346)

Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: angular#29785

PR Close angular#30346
@iget-master iget-master mentioned this pull request Jul 10, 2019
Closed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 15, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau

@angular/fw-integration fw-integration

Assignees
No one assigned
Labels
action: merge action: time-zone cla: yes comp: bazel target: patch
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@alan-agius4 @kyliau @googlebot