Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): change the week-numbering year format from r -> Y #39495

Closed
wants to merge 1 commit into from
Closed

fix(common): change the week-numbering year format from r -> Y #39495

wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Oct 29, 2020

This commit updates the week-numbering year format from r -> Y based on the description in
http://www.unicode.org/reports/tr35/tr35-dates.html#dfst-year.

Note: this is not a breaking change, since the week-numbering year format was introduced in
v11.0.0-next.3 (984ed39) and the major version that contains that change was not released yet.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
@AndrewKushnir
fix(common): change the week-numbering year format from `r` -> `Y`
47667e3 
This commit updates the week-numbering year format from `r` -> `Y` based on the description in
http://www.unicode.org/reports/tr35/tr35-dates.html#dfst-year.

Note: this is not a breaking change, since the week-numbering year format was introduced in
v11.0.0-next.3 (angular@984ed39)
and the major version that contains that change was not released yet.
@ngbot ngbot bot added this to the needsTriage milestone Oct 29, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 29, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 29, 2020
@google-cla google-cla bot added the cla: yes label Oct 29, 2020
petebacondarwin
petebacondarwin approved these changes Oct 30, 2020
View changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

LGTM - we need to ensure that the change log for 11.0.0 is correct with respect to this amendment to the original PR.

@petebacondarwin petebacondarwin mentioned this pull request Oct 30, 2020
Closed
@AndrewKushnir
Copy link
Contributor Author

@AndrewKushnir AndrewKushnir commented Oct 30, 2020

Presubmit.

josephperrott added a commit that referenced this issue Oct 30, 2020
@AndrewKushnir @josephperrott
fix(common): change the week-numbering year format from r -> Y (#…
feda78e 
…39495)

This commit updates the week-numbering year format from `r` -> `Y` based on the description in
http://www.unicode.org/reports/tr35/tr35-dates.html#dfst-year.

Note: this is not a breaking change, since the week-numbering year format was introduced in
v11.0.0-next.3 (984ed39)
and the major version that contains that change was not released yet.

PR Close #39495
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 30, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

Assignees
No one assigned
Labels
action: merge cla: yes comp: common target: rc type: bug/fix
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@AndrewKushnir @petebacondarwin