Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add PR reviews metrics. #1567
Add PR reviews metrics. #1567
Conversation
Adds two new metrics: - `NumberOfPRReviewDiffViewInlineCommentStartReview`: incremented when the "Start Review" button is clicked from an inline comment - `NumberOfPRReviewPosts`: incremented when a PR review is submitted
|
These metrics look good to me! Tested on VS2015 & VS2017 |
|
The first time I started a review from a diff and submitted that review it did not get recorded. I've tried twice since then and it worked. I'm going to try re-starting my experimental instance to see if the first one works when I re-start. |
|
Tests:
2015 Experimental:
2017 Experimental:
|
|
Looks good! Thanks for fixing that one bug. I have not been able to repro the first time that my metrics weren't updated, but I'm going to assume that was just funky with me for now. |
Adds two new metrics:
NumberOfPRReviewDiffViewInlineCommentStartReview: incremented when the "Start Review" button is clicked from an inline commentNumberOfPRReviewPosts: incremented when a PR review is submittedDepends on #1562
Part of #1491