Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Start PR Reviews from Inline Comments #1562
Conversation
You can't actually start the review yet though!
Track the current pending review to `PullRequestSession` along with methods to start reviews, post review comments and submit reviews.
|
This PR looks good to me I mainly followed scenarios that I outlined here Just a couple things to note:
For other errors don't we usually have a banner at the top (like
|
Yup, that's correct. I think the banner up there makes the most sense to show the error. |
Starting a review by replying to an existing comment was causing the submitted comment's text to be copied into the placeholder after submission. Add a unit test to check for this and fix it.
|
I agree with @meaghanlewis regarding the error message. I'm also noticing on VS2017 the font color is too dark for the changes list: I also noticed that if you have "" in your comments you get an error:
I took out the quotes and it worked fine. The interesting thing is that I started the inline comment, clicked "Start Your Review" and it started it, because I was able to see the "Continue your review", but the comment didn't actually get submitted until I took out the quotes. And I confirmed only one version of the inline comment was saved: Is that a known issue? |
…ature/pr-review-authoring
This PR adds a "Start a review" button to the inline comment peek view. When clicked it will start a pending review, and from this point all inline comments will be added to the pending review until the review is submitted:
Depends on #1549
Part of #1491