Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-13826: Clarify Popen constructor example #18438

Merged
merged 1 commit into from Feb 10, 2020

Conversation

tdsmith
Copy link
Contributor

@tdsmith tdsmith commented Feb 10, 2020

Clarifies that the use of shlex.split is more instructive than
normative, and provides a simpler example.

https://bugs.python.org/issue13826

Automerge-Triggered-By: @gvanrossum

Clarifies that the use of `shlex.split` is more instructive than
normative, and provides a simpler example.
@tdsmith
Copy link
Contributor Author

tdsmith commented Feb 10, 2020

Updated to use a more cross-platform example (git instead of say).

Copy link
Member

@gvanrossum gvanrossum left a comment

Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

@tdsmith: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 95d024d into python:master Feb 10, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

Thanks @tdsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Feb 10, 2020

GH-18445 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
Clarifies that the use of `shlex.split` is more instructive than
normative, and provides a simpler example.

https://bugs.python.org/issue13826
(cherry picked from commit 95d024d)

Co-authored-by: Tim D. Smith <github@tim-smith.us>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
Clarifies that the use of `shlex.split` is more instructive than
normative, and provides a simpler example.

https://bugs.python.org/issue13826
(cherry picked from commit 95d024d)

Co-authored-by: Tim D. Smith <github@tim-smith.us>
@bedevere-bot
Copy link

bedevere-bot commented Feb 10, 2020

GH-18446 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 10, 2020
Clarifies that the use of `shlex.split` is more instructive than
normative, and provides a simpler example.

https://bugs.python.org/issue13826
(cherry picked from commit 95d024d)

Co-authored-by: Tim D. Smith <github@tim-smith.us>
miss-islington added a commit that referenced this pull request Feb 10, 2020
Clarifies that the use of `shlex.split` is more instructive than
normative, and provides a simpler example.

https://bugs.python.org/issue13826
(cherry picked from commit 95d024d)

Co-authored-by: Tim D. Smith <github@tim-smith.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants