Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesMark importlib and clinic headers as generated #7619
Merged
Conversation
|
Looks good, but there are several other generated files that we could also list here, like the unicodedata files, graminit, python-ast, etc. |
This comment has been minimized.
This comment has been minimized.
|
I removed the |
|
LGTM. |
This comment has been minimized.
This comment has been minimized.
|
It doesn't hide diffs completely, but just makes them collapsed by default? Then LGTM! |
c1897ed
into
python:master
9 checks passed
9 checks passed
bedevere/issue-number
Issue report skipped
bedevere/news
"skip news" label found
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jun 15, 2018
|
Thanks @methane for the PR |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jun 15, 2018
|
GH-7707 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jun 15, 2018
|
GH-7708 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
It doesn't hide diffs completely, but just makes them collapsed by default?
You are right. Generated files are collapsed by default. Reviewer can
uncollapse them when they want.
--
INADA Naoki <songofacandy@gmail.com>
|
miss-islington
added a commit
that referenced
this pull request
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
lisroach
added a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguist#generated-code
yahya-abou-imran
added a commit
to yahya-abou-imran/cpython
that referenced
this pull request
Nov 2, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguist#generated-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
methane commentedJun 11, 2018
•
edited
We can specify generated files in
.gitattributes.Github doesn't render diff for generated files by default.
Sample pull request