Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfunction "statsToString" only prints the size of the first file #16627
Comments
This comment has been minimized.
This comment has been minimized.
|
That's indeed not great :( I'm surprised it took this long to come up too! Would you be interested in taking a look? |
This comment has been minimized.
This comment has been minimized.
|
I'll try to take a look at it! |
This comment has been minimized.
This comment has been minimized.
|
I don't think we have a good way of testing this change... If I were looking into this, I'd first start with a real project that I know is doing the wrong thing. Then I'd go directly into node modules and change the code to do the right thing. Then I'd make a PR with those changes, and put in the PR message a before and after screenshot. Rather informal but I think that's what we did the last few times we changes the logging format. |
This comment has been minimized.
This comment has been minimized.
|
Can you also provide an example webpack configuration that exhibits the issue described above? |
This comment has been minimized.
This comment has been minimized.
|
@filipesilva Ok -Edit |
…chunk during the build statistic print. Fixes: angular#16627
Command (mark with an
x)Is this a regression?
No
Description
I'm CLI-izing an old application and to do so, i've set up the build target with
@angular-builders/custom-webpack:browserMy
webpack.config.jsemits themain_client.jstogether with aninitial.css,when this happens, the Angular-CLI function
statsToStringonly prints the size of the first file it encounters like so:which generates this not-so-good report where the sizes are 73KB for
initial.cssand around 8MB formain-client.jsNow, i know i'm not supposed to use my own webpack with the CLI etc.. etc.. etc.. but since the logger actually prints all initial file's names i would assume it would also sum their sizes?
Still, the build is somehow working and I'm already quite happy about that, but if you guys could fix up the size count of the initial chunk, that would be terrific! :)
Thanks!