Correctly prints the size of the chunk during the build statistic print#16734
Correctly prints the size of the chunk during the build statistic print#16734kyliau merged 1 commit intoangular:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
EmaGht
left a comment
There was a problem hiding this comment.
refactored the accumulation function and excluded .map files!
|
Can you squash the commits? |
|
Can you please also reference #16627 in the commit footer? Ex: |
…chunk during the build statistic print. Fixes: angular#16627
|
@clydin First time squashing, hopefully everything went according to plan 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commits allows the cli to correctly print the sum of the sizes of the assets of a given chunk instead of the size of the first emitted asset
Attached:
-Before.PNG: What was happening before the fix in my local environment
-After.PNG: What's happening after the fix, notice that now the size of the "main-client" is the actual sum of the sizes of main-client.js and initial.css
-webpack.config.js: As requested, my current webpack configuration. This problem happens when i'm using the MiniCssExtractPlugin to extract my initial.css together with the main client
Before.PNG

After.PNG
