Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document that stream.on('close') was changed in Node 10. #25413

Closed
wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

commented Jan 9, 2019

See: #25373
See: #18438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 9, 2019

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2200/pipeline

@nodejs-github-bot nodejs-github-bot added doc stream labels Jan 9, 2019

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 9, 2019

cc @mafintosh

@mcollina mcollina requested review from addaleax and mafintosh Jan 9, 2019

@richardlau richardlau added dont-land-on-v6.x dont-land-on-v8.x lts-watch-v10.x labels Jan 9, 2019

@richardlau
richardlau approved these changes Jan 9, 2019
View changes
@sam-github
sam-github reviewed Jan 9, 2019
View changes
doc/api/stream.md Outdated Show resolved Hide resolved
@jasnell
jasnell approved these changes Jan 9, 2019
View changes
sam-github added a commit to sam-github/node that referenced this pull request Jan 9, 2019
@sam-github
doc: wrap and punctuate YAML description text 
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: nodejs#25413 (comment)
ad5cc6b
@sam-github sam-github referenced this pull request Jan 9, 2019
Closed
3 of 3 tasks complete
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 9, 2019

@sam-github do you prefer this to rebase on top of #25419?
@vsemozhetbyt
vsemozhetbyt reviewed Jan 9, 2019
View changes
doc/api/stream.md Outdated Show resolved Hide resolved
@vsemozhetbyt
vsemozhetbyt reviewed Jan 9, 2019
View changes
doc/api/stream.md Outdated Show resolved Hide resolved
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

@mcollina sure, rebase or squash and close my PR, if you wish. If you don't, I'll just rebase #25419 onto master once this lands, and cleanup there. Its nbd either way.
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 9, 2019

No I mean, you land that, and then I amend this one? Or the contrary?
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

Actually, #25419 was fast-tracked so I guess rebasing this one would be the way to go. Sorry, I process github notifications sequentially!
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

And it landed (I'm sure you'll notice).

@sam-github sam-github closed this in c2d8a54 Jan 9, 2019

@mcollina mcollina reopened this Jan 9, 2019

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 9, 2019

Reopening this one because it was closed by github.
@BridgeAR
BridgeAR approved these changes Jan 10, 2019
View changes
@mcollina
doc: document that stream.on('close') was changed in Node 10 
See: #25373
See: #18438
Loading status checks…
401ca19

@mcollina mcollina force-pushed the mcollina:close-event-stream branch from 93d579b to 401ca19 Jan 10, 2019

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 10, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2221/
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 10, 2019 •
edited

@sam-github @vsemozhetbyt check it out!
@sam-github
sam-github approved these changes Jan 10, 2019
View changes
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 12, 2019

Landed in 18d3aeb

@mcollina mcollina closed this Jan 12, 2019

@mcollina mcollina deleted the mcollina:close-event-stream branch Jan 12, 2019

mcollina added a commit that referenced this pull request Jan 12, 2019
@mcollina
doc: document that stream.on('close') was changed in Node 10 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Loading status checks…
18d3aeb
addaleax added a commit that referenced this pull request Jan 14, 2019
@sam-github @addaleax
doc: wrap and punctuate YAML description text 
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: #25413 (comment)

PR-URL: #25419
Fixes: #25413
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
f58b530
addaleax added a commit that referenced this pull request Jan 14, 2019
@mcollina @addaleax
doc: document that stream.on('close') was changed in Node 10 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
b67c4b4
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@sam-github @BridgeAR
doc: wrap and punctuate YAML description text 
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: nodejs#25413 (comment)

PR-URL: nodejs#25419
Fixes: nodejs#25413
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
4624a5d
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@mcollina @BridgeAR
doc: document that stream.on('close') was changed in Node 10 
See: nodejs#25373
See: nodejs#18438

PR-URL: nodejs#25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
f23b4c3
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@mcollina @BethGriggs
doc: document that stream.on('close') was changed in Node 10 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
f7491d4
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@mcollina @BethGriggs
doc: document that stream.on('close') was changed in Node 10 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
67db596
MylesBorins added a commit that referenced this pull request May 16, 2019
@mcollina @MylesBorins
doc: document that stream.on('close') was changed in Node 10 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
0c33ecb
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed

@BethGriggs BethGriggs added land-on-v10.x and removed lts-watch-v10.x labels Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt

@sam-github sam-github

@jasnell jasnell

@richardlau richardlau

@BridgeAR BridgeAR

@mafintosh mafintosh

@addaleax addaleax

Assignees
No one assigned
Labels
doc dont-land-on-v8.x land-on-v10.x stream
Projects
None yet
Milestone
No milestone
8 participants
@mcollina @nodejs-github-bot @sam-github @jasnell @richardlau @BridgeAR @vsemozhetbyt @BethGriggs
You can’t perform that action at this time.