Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix asmdef files giving errors on 2018.3 #1001
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
shana commentedJan 18, 2019
Pulling in #1000 and adding some additional fixes. Dark mode was broken (because Unity is importing icons differently from the filesystem I guess?), and I let Unity regenerate the asmdef file, which changed it subtly. This is on 2018.3.0, so I want to do it on 2018.3.1 as well and then add the ProjectVersion.txt file to signal what version the project is actually on (because it's kinda important).