Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix asmdef files giving errors on 2018.3 #1000

Conversation

@sambonfire
Copy link
Contributor

sambonfire commented Jan 18, 2019

Description of the Change

I've updated the .asmdef files so that you can do the quick debugging workflow using Unity 2018.3. Discussed this with Shana on Discord.

Benefits

This allows developers the quick iteration of loading the GUI code directly in Unity

Possible Drawbacks

Older versions of Unity will be broken

@shana
shana approved these changes Jan 18, 2019
Copy link
Contributor

shana left a comment

Yeah, it sucks a lot that they keep changing the format on this file. I'm fine with upping the required version for it to 2018.3. This is only for developing the extension itself and doesn't affect the actual build of it, and we should always probably track the latest Unity release so that we can incorporate new APIs into the shim as they become available.

@shana shana changed the base branch from master to pr/1000-fix-asmdef-files-giving-errors-on-2018-3 Jan 18, 2019
@shana shana merged commit 9609f31 into github-for-unity:pr/1000-fix-asmdef-files-giving-errors-on-2018-3 Jan 18, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sambonfire sambonfire deleted the bonfirestudios:fix-asmdef branch Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.