Actions
Bug #72463
closedTasks #63293: Implement fscrypt in libcephfs and cephfs-fuse
remove write_file from vstart_runner.py
% Done:
0%
Source:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Tags (freeform):
Merge Commit:
Fixed In:
Released In:
Upkeep Timestamp:
Description
The addition of write_file into vstart_runner.py blocks use of write_file in teuthology's remote.py (added here https://github.com/ceph/ceph/pull/60833).
The purpose of LocalRemote extending RemoteShell is to inherit the already defined method. In most cases, we shouldn't have to redefine methods.
The write_file in remote.py has additional parameters and fails when using vstart_runner.py.
Test writing data with huge hole, half write on previous block and trailing on new block in 47.425187s 2025-08-07 13:08:54,724.724 INFO:__main__: 2025-08-07 13:08:54,724.724 INFO:__main__:====================================================================== 2025-08-07 13:08:54,724.724 INFO:__main__:ERROR: test_fscrypt_huge_hole (tasks.cephfs.test_fscrypt.TestFSCryptRMW.test_fscrypt_huge_hole) 2025-08-07 13:08:54,724.724 INFO:__main__:Test writing data with huge hole, half write on previous block and trailing on new block 2025-08-07 13:08:54,724.724 INFO:__main__:---------------------------------------------------------------------- 2025-08-07 13:08:54,725.725 INFO:__main__:Traceback (most recent call last): 2025-08-07 13:08:54,725.725 INFO:__main__: File "test_fscrypt.py", line 128, in test_fscrypt_huge_hole 2025-08-07 13:08:54,725.725 INFO:__main__: self.mount_a.write_file_ex(path=file, bs=1, data=contents, offset=offset) 2025-08-07 13:08:54,725.725 INFO:__main__: File "qa/tasks/cephfs/mount.py", line 728, in write_file_ex 2025-08-07 13:08:54,725.725 INFO:__main__: self.client_remote.write_file(path, data, **kwargs) 2025-08-07 13:08:54,725.725 INFO:__main__:TypeError: LocalRemote.write_file() got an unexpected keyword argument 'bs' 2025-08-07 13:08:54,726.726 INFO:__main__:
When write_file is removed from vstart_runner.py the above passes.
Updated by Christopher Hoffman 7 months ago
- Status changed from New to In Progress
- Assignee set to Christopher Hoffman
Updated by Christopher Hoffman 7 months ago
- Project changed from Ceph to CephFS
- Parent task set to #63293
Updated by Christopher Hoffman 7 months ago
- Status changed from In Progress to Resolved
Actions