Skip to content

qa/vstart_runner: Add get_file and write_file equivalents to the LocalRemoteProcess class#60833

Merged
kamoltat merged 1 commit intoceph:mainfrom
connorfawcett:wip-vstart-runner-fns2
May 27, 2025
Merged

qa/vstart_runner: Add get_file and write_file equivalents to the LocalRemoteProcess class#60833
kamoltat merged 1 commit intoceph:mainfrom
connorfawcett:wip-vstart-runner-fns2

Conversation

@connorfawcett
Copy link
Contributor

This PR adds write_file and get_file functions to the vstart_runner LocalRemoteProcess class, allowing tests which rely on the equivalent functions in the RemoteProcess class to be run on a vstart cluster. The functions mirror the functionality of remote variants as much as possible for consistency purposes between local runs and teuthology runs.

Signed-off by: Connor Fawcett connorfa@uk.ibm.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the tests label Nov 26, 2024
@kamoltat kamoltat requested a review from a team December 13, 2024 06:16
@connorfawcett
Copy link
Contributor Author

jenkins test make check

@connorfawcett
Copy link
Contributor Author

jenkins test make check arm64

@connorfawcett
Copy link
Contributor Author

jenkins test make check

@connorfawcett
Copy link
Contributor Author

jenkins test make check arm64

@connorfawcett connorfawcett requested review from a team and kamoltat and removed request for a team and kamoltat March 14, 2025 13:31
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 13, 2025
@kamoltat kamoltat removed the stale label May 21, 2025
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 minor comment.
Thank you for enhancing the vstart_runner test tool.

…lRemoteProcess class

Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
@connorfawcett connorfawcett force-pushed the wip-vstart-runner-fns2 branch from 17e2ce7 to 53c3d73 Compare May 26, 2025 23:38
@connorfawcett
Copy link
Contributor Author

jenkins test make check

@kamoltat kamoltat merged commit bf95acd into ceph:main May 27, 2025
12 checks passed
@connorfawcett connorfawcett deleted the wip-vstart-runner-fns2 branch May 27, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants