Project

General

Profile

Actions

Bug #70180

closed

PGRecovery::budget_available: re-enable try_acquire_throttle_now usage

Added by MOHIT AGRAWAL about 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

100%

Source:
Backport:
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Fixed In:
v20.0.0-1182-g9cb8feb327
Released In:
v20.2.0~650
Upkeep Timestamp:
2025-11-01T01:14:16+00:00

Description

In order to use the throttler crimson_osd_scheduler_concurrency value is needed to be set more than (default) 0.
Once configuring non zero value, the PG recovery progress is stuck because
try_acquire_throttle_now is not releasing the throttler.

Until this behavior is fixed https://github.com/ceph/ceph/pull/62006 comments out the faulty try_acquire_throttle_now call.
We should resolve this tracker once we re-enable PGRecovery::budget_available.


Subtasks 1 (0 open1 closed)

Bug #70395: Use throttler for backfill operationDuplicateMOHIT AGRAWAL

Actions
Actions #1

Updated by MOHIT AGRAWAL about 1 year ago

  • Pull request ID set to 62006
Actions #2

Updated by MOHIT AGRAWAL about 1 year ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Matan Breizman about 1 year ago

  • Subject changed from pg_recovery progress is stuck while throttle feature is used to PGRecovery::budget_available: re-enable try_acquire_throttle_now usage
  • Description updated (diff)
  • Status changed from Fix Under Review to New
  • Pull request ID deleted (62006)

https://github.com/ceph/ceph/pull/62006 is a indeterminate workaround that comments out the code which is responsible for the issue.
Moving back to "New", Let's use this tracker to follow up on the required changes.
Adjusting the title and description.

Actions #4

Updated by Matan Breizman about 1 year ago

Update: https://github.com/ceph/ceph/pull/62080 reverts some of the commits instead of https://github.com/ceph/ceph/pull/62006.
This tracker is still relevant.

Actions #5

Updated by MOHIT AGRAWAL 12 months ago

  • Subtask #70395 added
Actions #6

Updated by Matan Breizman 11 months ago

  • Status changed from New to Resolved
  • Pull request ID set to 62080
Actions #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 9cb8feb327bd2065fd92218c546a5c7d1f1d90c6
  • Fixed In set to v20.0.0-1182-g9cb8feb327b
  • Upkeep Timestamp set to 2025-07-09T19:36:44+00:00
Actions #8

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v20.0.0-1182-g9cb8feb327b to v20.0.0-1182-g9cb8feb327
  • Upkeep Timestamp changed from 2025-07-09T19:36:44+00:00 to 2025-07-14T18:13:44+00:00
Actions #9

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~650
  • Upkeep Timestamp changed from 2025-07-14T18:13:44+00:00 to 2025-11-01T01:14:16+00:00
Actions

Also available in: Atom PDF