crimson: Avoid to call try_acquire_throttle_now via budget_available#62006
crimson: Avoid to call try_acquire_throttle_now via budget_available#62006
Conversation
|
jenkins test make check |
There was a problem hiding this comment.
It's not completely "Fixes" the issue described but only avoids it for now.
Can you please add the tracker as a comment above the commented out code? That way it should be easier to understand the context over why it's commented out.
edit: instead of creating a tracker which fixes the issue by avoiding it - I've updated the tracker so that it reflects the required changes - See: https://tracker.ceph.com/issues/70180.
Avoid try_acquire_throttle_now via budget_available and return a true due to this the recovery progress is stuck because try_acquire_throttle_now increase the counter(in_progress) but does not release a throttle to decrease the counter. Fixes: #https://tracker.ceph.com/issues/70180 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
79d3d0a to
2d54369
Compare
done |
|
jenkins test make check |
|
Sorry, I forgot to implement the throttler releasing in BackfillState, will fix it. |
|
@xxhdx1985126 pushed a PR with a full revert of the faulty commit - #62080 |
I am ok if #62080 only revert the commit but the pull request has one more change. I think @xxhdx1985126 need to refresh the pull request. for the other change related to introduce per pg push limit we should merge via new tracker bug. |
|
Let's keep #62080 as is. If this issue blocks you in other work - we can push the revert here and merge it separately. Otherwise, let's wait for the other PR to merge and we could close this PR in this case. |
|
I am closing the pull request , the earlier change will revert via #62080 |
Avoid try_acquire_throttle_now via budget_available and return a true due to this the recovery progress is stuck because try_acquire_throttle_now increase the counter(in_progress) but does not release a throttle to decrease the counter.
Fixes: #https://tracker.ceph.com/issues/70180
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e