Project

General

Profile

Actions

Bug #69471

closed

make check fails on reef PRs (4 - run-tox-mgr (Failed))

Added by Yuri Weinstein about 1 year ago. Updated 9 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
diskprediction_local
Target version:
-
% Done:

0%

Source:
Q/A
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Fixed In:
v18.2.4-1369-g8a122fae854
Released In:
v18.2.5~200
Upkeep Timestamp:
2025-07-10T00:36:03+00:00

Description

https://github.com/ceph/ceph/pull/61171

https://jenkins.ceph.com/job/ceph-pull-requests/149190/

1 tests failed out of 283

Total Test time (real) = 2475.41 sec

The following tests FAILED:
      4 - run-tox-mgr (Failed)

I have several PRs with similar (maybe not the same issues)
https://github.com/ceph/ceph/pull/61094
https://github.com/ceph/ceph/pull/61167

Actions #1

Updated by John Mulligan about 1 year ago

mypy is no longer passing on the reef branch:

mypy: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> mypy --config-file=../../mypy.ini -m alerts -m balancer -m cephadm -m crash -m dashboard -m devicehealth -m diskprediction_local -m hello -m influx -m iostat -m localpool -m mds_autoscaler -m mgr_module -m mgr_util -m mirroring -m nfs -m orchestrator -m pg_autoscaler -m progress -m prometheus -m rbd_support -m rgw -m rook -m snap_schedule -m selftest -m stats -m status -m telegraf -m telemetry -m test_orchestrator -m volumes -m zabbix
diskprediction_local/module.py:17: note: In module imported here,
diskprediction_local/__init__.py:2: note: ... from here:
diskprediction_local/predictor.py: note: In member "__preprocess" of class "RHDiskFailurePredictor":
diskprediction_local/predictor.py:160: error: _ArrayT? has no attribute "reshape" 
diskprediction_local/predictor.py:161: error: Unsupported left operand type for + (_ShapeT_co?)
Found 2 errors in 1 file (checked 32 source files)

There have not been any code changes in this for a while so we suspect something external changed, such as python lang. version. However, the plan is to just "bandaid" it rather than root cause it because many people need their reef backports to pass!

Actions #2

Updated by John Mulligan about 1 year ago

  • Project changed from Infrastructure to mgr
  • Category set to diskprediction_local
  • Status changed from New to In Progress
  • Assignee set to John Mulligan
  • Pull request ID set to 61292
Actions #3

Updated by Adam King about 1 year ago

  • Status changed from In Progress to Resolved
Actions #4

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to 8a122fae8547c61c9f4fd37c87e89fac461e3e71
  • Fixed In set to v18.2.4-1369-g8a122fae854
  • Released In set to v18.2.5~200
  • Upkeep Timestamp set to 2025-07-10T00:36:03+00:00
Actions

Also available in: Atom PDF