Skip to content

reef: rbd: handle --{group,image}-namespace in "rbd group image {add,rm}"#61171

Merged
sunilangadi2 merged 2 commits intoceph:reeffrom
idryomov:wip-69324-reef
Jan 17, 2025
Merged

reef: rbd: handle --{group,image}-namespace in "rbd group image {add,rm}"#61171
sunilangadi2 merged 2 commits intoceph:reeffrom
idryomov:wip-69324-reef

Conversation

@idryomov
Copy link
Contributor

Currently only passing the namespace as part of the group or image spec
works.  If --group-namespace or --image-namespace options are used, the
namespace isn't picked up.

Fixes: https://tracker.ceph.com/issues/69324
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit f35e3a6)

Conflicts:
	src/tools/rbd/action/Group.cc [ "rbd group info" and "rbd group
	  snap info" commands not in reef ]
It stopped working with removal of get_special_pool_group_names() in
commit 3e8624f ("rbd: add support for namespaces") over six years
ago.  Given how much time has passed, stop accepting this option.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1f71671)
@idryomov idryomov added this to the v18.2.5 milestone Dec 23, 2024
@idryomov idryomov requested a review from a team as a code owner December 23, 2024 09:48
@idryomov
Copy link
Contributor Author

jenkins test make check

@idryomov
Copy link
Contributor Author

jenkins test api

@sunilangadi2
Copy link

jenkins test make check

2 similar comments
@yuriw
Copy link
Contributor

yuriw commented Jan 7, 2025

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented Jan 8, 2025

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented Jan 10, 2025

This is ready for merge as soon as make check passed
ref: https://tracker.ceph.com/issues/69414

@yuriw
Copy link
Contributor

yuriw commented Jan 13, 2025

jenkins test make check

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Jan 16, 2025

jenkins test make check

@sunilangadi2 sunilangadi2 merged commit cf55678 into ceph:reef Jan 17, 2025
@idryomov idryomov deleted the wip-69324-reef branch January 17, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants