Project

General

Profile

Actions

Cleanup #66383

closed

QuiesceDbRequest: update how operations are encoded internally

Added by Leonid Usov almost 2 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Backport:
squid
Reviewed:
Affected Versions:
Component(FS):
quiesce
Labels (FS):
Pull request ID:
Tags (freeform):
Fixed In:
v19.3.0-2590-gd3b710a31b
Released In:
v20.2.0~2755
Upkeep Timestamp:
2025-11-01T01:22:07+00:00

Description

While reviewing the code for the QuiesceDb presentation, it became obvious that the internal representation of the exclude/cancel/reset/release operations could be improved. Specifically, since excluding the last root from a set will automatically mark it as QS_CANCELED, `exclude` and `cancel` should share the op code, rather than `exclude` and `release`, as it was implemented originally.

I can confirm that the original intention was to combine the operations logically, but something went wrong :D


Related issues 1 (0 open1 closed)

Copied to CephFS - Backport #66400: squid: QuiesceDbRequest: update how operations are encoded internallyResolvedLeonid UsovActions
Actions #1

Updated by Leonid Usov almost 2 years ago

  • Subject changed from QuiesceDbRequest: update how supported operations are encoded to QuiesceDbRequest: update how operations are encoded internally
Actions #2

Updated by Leonid Usov almost 2 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 57912
Actions #3

Updated by Leonid Usov almost 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #66400: squid: QuiesceDbRequest: update how operations are encoded internally added
Actions #6

Updated by Upkeep Bot 9 months ago

  • Status changed from Pending Backport to Resolved
  • Upkeep Timestamp set to 2025-07-08T18:35:45+00:00
Actions #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to d3b710a31b80c6bd60dba567647a6b5b3b5e0194
  • Fixed In set to v19.3.0-2590-gd3b710a31b
  • Upkeep Timestamp changed from 2025-07-08T18:35:45+00:00 to 2025-08-02T04:50:59+00:00
Actions #8

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~2755
  • Upkeep Timestamp changed from 2025-08-02T04:50:59+00:00 to 2025-11-01T01:22:07+00:00
Actions

Also available in: Atom PDF