mds: QuiesceDbRequest: update the internal encoding of ops#57912
Merged
leonid-s-usov merged 1 commit intomainfrom Jun 8, 2024
Merged
mds: QuiesceDbRequest: update the internal encoding of ops#57912leonid-s-usov merged 1 commit intomainfrom
leonid-s-usov merged 1 commit intomainfrom
Conversation
Excluding the last root from a set will automatically mark it as QS_CANCELED. Hence, it makes more sense if `exclude` and `cancel` share the same op code, rather than `exclude` and `release`. Signed-off-by: Leonid Usov <leonid.usov@ibm.com> Fixes: https://tracker.ceph.com/issues/66383
batrick
approved these changes
Jun 6, 2024
Contributor
Author
|
Functional tests pass: https://pulpito.ceph.com/leonidus-2024-06-07_08:29:57-fs:functional-wip-lusov-quiesce-distro-default-smithi/ with-quiesce: https://pulpito.ceph.com/leonidus-2024-06-07_08:30:28-fs-wip-lusov-quiesce-distro-default-smithi/ 5 total failures vs 25 passed. 2 cases of the teuthology command timeout with status 124. Both are cases of messenger failures
This PR is safe to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excluding the last root from a set will automatically mark it as QS_CANCELED. Hence, it makes more sense if
excludeandcancelshare the same op code, rather thanexcludeandrelease.Fixes: https://tracker.ceph.com/issues/66383
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e