Project

General

Profile

Actions

Bug #65183

closed

Overriding an EC pool needs the "--yes-i-really-mean-it" flag in addition to "force"

Added by Laura Flores almost 2 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
% Done:

100%

Source:
Development
Backport:
squid, reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Tags (freeform):
backport_processed
Fixed In:
v19.3.0-2989-gf939c35f05
Released In:
v20.2.0~2623
Upkeep Timestamp:
2025-11-01T01:33:57+00:00

Description

/a/yuriw-2024-03-26_14:32:05-rados-wip-yuri8-testing-2024-03-25-1419-distro-default-smithi/7623454

2024-03-26T20:13:29.028 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:35: expect_false:  set -x
2024-03-26T20:13:29.028 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:36: expect_false:  ceph osd erasure-code-profile set fooprofile a=b c=d e=f
2024-03-26T20:13:29.301 INFO:tasks.workunit.client.0.smithi110.stderr:Error EPERM: will not override erasure code profile fooprofile because the existing profile {a=b,c=d,crush-device-class=,crush-failure-domain=osd,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,jerasure-per-chunk-alignment=false,k=2,m=1,plugin=jerasure,technique=reed_sol_van,w=8} is different from the proposed profile {a=b,c=d,crush-device-class=,crush-failure-domain=osd,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,e=f,jerasure-per-chunk-alignment=false,k=2,m=1,plugin=jerasure,technique=reed_sol_van,w=8}
2024-03-26T20:13:29.304 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:36: expect_false:  return 0
2024-03-26T20:13:29.304 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:2493: test_mon_osd_erasure_code:  ceph osd erasure-code-profile set fooprofile a=b c=d e=f --force
2024-03-26T20:13:29.581 INFO:tasks.workunit.client.0.smithi110.stderr:Error EPERM: overriding erasure code profile can be DANGEROUS; add --yes-i-really-mean-it to do it anyway
2024-03-26T20:13:29.585 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:1: test_mon_osd_erasure_code:  rm -fr /tmp/cephtool.wZw
2024-03-26T20:13:29.586 DEBUG:teuthology.orchestra.run:got remote process result: 1
2024-03-26T20:13:29.587 INFO:tasks.workunit:Stopping ['cephtool'] on client.0...

Here's the test that fails:
qa/workunits/cephtool/test.sh

function test_mon_osd_erasure_code()
{

  ceph osd erasure-code-profile set fooprofile a=b c=d
  ceph osd erasure-code-profile set fooprofile a=b c=d
  expect_false ceph osd erasure-code-profile set fooprofile a=b c=d e=f
  ceph osd erasure-code-profile set fooprofile a=b c=d e=f --force      ---------------------> this one
  ceph osd erasure-code-profile set fooprofile a=b c=d e=f
  expect_false ceph osd erasure-code-profile set fooprofile a=b c=d e=f g=h
  # make sure rule-foo doesn't work anymore
  expect_false ceph osd erasure-code-profile set barprofile ruleset-failure-domain=host
  ceph osd erasure-code-profile set barprofile crush-failure-domain=host
  # clean up
  ceph osd erasure-code-profile rm fooprofile
  ceph osd erasure-code-profile rm barprofile

  # try weird k and m values
  expect_false ceph osd erasure-code-profile set badk k=1 m=1
  expect_false ceph osd erasure-code-profile set badk k=1 m=2
  expect_false ceph osd erasure-code-profile set badk k=0 m=2
  expect_false ceph osd erasure-code-profile set badk k=-1 m=2
  expect_false ceph osd erasure-code-profile set badm k=2 m=0
  expect_false ceph osd erasure-code-profile set badm k=2 m=-1
  ceph osd erasure-code-profile set good k=2 m=1
  ceph osd erasure-code-profile rm good
}


Subtasks 1 (0 open1 closed)

Bug #66611: qa/workunits/cephtool/test.sh: Error EPERM: overriding erasure code profile can be DANGEROUS; add --yes-i-really-mean-it to do it anywayDuplicate

Actions

Related issues 3 (0 open3 closed)

Has duplicate RADOS - Bug #67754: rados: cannot update profile with --force and --yes-i-really-mean-itDuplicateSamuel Just

Actions
Copied to RADOS - Backport #66690: squid: Overriding an EC pool needs the "--yes-i-really-mean-it" flag in addition to "force"ResolvedAishwarya MathuriaActions
Copied to RADOS - Backport #66691: reef: Overriding an EC pool needs the "--yes-i-really-mean-it" flag in addition to "force"ResolvedKonstantin ShalyginActions
Actions #1

Updated by Laura Flores almost 2 years ago

Likely coming from this change:
https://github.com/ceph/ceph/pull/56287

Actions #2

Updated by Radoslaw Zarzynski almost 2 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Radoslaw Zarzynski
  • Pull request ID set to 56531
Actions #3

Updated by Laura Flores almost 2 years ago

Also needs to be fixed for qa/standalone/mon/osd-erasure-code-profile.sh:

/a/yuriw-2024-04-01_20:57:46-rados-wip-yuri3-testing-2024-04-01-0837-squid-distro-default-smithi/7634757

2024-04-02T04:26:16.310 INFO:tasks.workunit.client.0.smithi107.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:62: TEST_set:  grep 'will not override' td/osd-erasure-code-profile/out
2024-04-02T04:26:16.311 INFO:tasks.workunit.client.0.smithi107.stdout:Error EPERM: will not override erasure code profile myprofile because the existing profile {crush-device-class=,crush-failure-domain=host,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,k=7,key=value,m=3,plugin=isa,technique=reed_sol_van} is different from the proposed profile {crush-device-class=,crush-failure-domain=host,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,jerasure-per-chunk-alignment=false,k=2,m=2,plugin=jerasure,technique=reed_sol_van,w=8}
2024-04-02T04:26:16.311 INFO:tasks.workunit.client.0.smithi107.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:63: TEST_set:  ceph osd erasure-code-profile set myprofile key=other --force
2024-04-02T04:26:16.459 INFO:tasks.workunit.client.0.smithi107.stderr:Error EPERM: overriding erasure code profile can be DANGEROUS; add --yes-i-really-mean-it to do it anyway
2024-04-02T04:26:16.462 INFO:tasks.workunit.client.0.smithi107.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:63: TEST_set:  return 1

Actions #4

Updated by Laura Flores almost 2 years ago

  • Backport set to squid
Actions #5

Updated by Laura Flores almost 2 years ago · Edited

/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647523
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647366
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647663
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647809
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647747

Actions #6

Updated by Matan Breizman almost 2 years ago

/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659300
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659372
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659443
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659482
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659512

Actions #7

Updated by Laura Flores almost 2 years ago

/a/yuriw-2024-04-20_15:32:38-rados-wip-yuriw-testing-20240419.185239-main-distro-default-smithi/7664685

Actions #8

Updated by Matan Breizman almost 2 years ago

  • Backport changed from squid to squid, reef

/a/yuriw-2024-04-20_01:10:46-rados-wip-yuri7-testing-2024-04-18-1351-reef-distro-default-smithi/7664087

Actions #9

Updated by Sridhar Seshasayee almost 2 years ago

Observed on Squid:
/a/yuriw-2024-04-30_03:21:19-rados-wip-yuri4-testing-2024-04-29-0642-distro-default-smithi/7680152
/a/yuriw-2024-04-30_03:21:19-rados-wip-yuri4-testing-2024-04-29-0642-distro-default-smithi/7680221
/a/yuriw-2024-04-30_03:21:19-rados-wip-yuri4-testing-2024-04-29-0642-distro-default-smithi/7680292
/a/yuriw-2024-04-30_03:21:19-rados-wip-yuri4-testing-2024-04-29-0642-distro-default-smithi/7680332
/a/yuriw-2024-04-30_03:21:19-rados-wip-yuri4-testing-2024-04-29-0642-distro-default-smithi/7680362

Actions #10

Updated by Aishwarya Mathuria almost 2 years ago

/a/yuriw-2024-04-30_14:17:59-rados-wip-yuri5-testing-2024-04-17-1400-distro-default-smithi/7680989
/a/yuriw-2024-04-30_14:17:59-rados-wip-yuri5-testing-2024-04-17-1400-distro-default-smithi/7681037
/a/yuriw-2024-04-30_14:17:59-rados-wip-yuri5-testing-2024-04-17-1400-distro-default-smithi/7680942
/a/yuriw-2024-04-30_14:17:59-rados-wip-yuri5-testing-2024-04-17-1400-distro-default-smithi/7681087
/a/yuriw-2024-04-30_14:17:59-rados-wip-yuri5-testing-2024-04-17-1400-distro-default-smithi/7681132

Actions #11

Updated by Nitzan Mordechai almost 2 years ago

/a/yuriw-2024-05-04_16:45:43-rados-wip-yuriw-testing-20240503.213524-main-distro-default-smithi/7691175
/a/yuriw-2024-05-04_16:45:43-rados-wip-yuriw-testing-20240503.213524-main-distro-default-smithi/7691015
/a/yuriw-2024-05-04_16:45:43-rados-wip-yuriw-testing-20240503.213524-main-distro-default-smithi/7691253
/a/yuriw-2024-05-04_16:45:43-rados-wip-yuriw-testing-20240503.213524-main-distro-default-smithi/7691092

Actions #12

Updated by Radoslaw Zarzynski almost 2 years ago

Not merged yet so the reoccurrences are expected.

Actions #13

Updated by Matan Breizman almost 2 years ago

/a/yuriw-2024-05-29_14:57:51-rados-wip-yuri5-testing-2024-05-15-0804-distro-default-smithi/7732514 and 7732522, 7732533, 7732540

Actions #14

Updated by Aishwarya Mathuria almost 2 years ago · Edited

/a/yuriw-2024-06-04_18:11:47-rados-wip-yuri4-testing-2024-05-28-1212-distro-default-smithi/7740886/
/a/yuriw-2024-06-04_18:11:47-rados-wip-yuri4-testing-2024-05-28-1212-distro-default-smithi/7740953

Actions #15

Updated by Radoslaw Zarzynski almost 2 years ago

Scrub note: will drill through the new teuthology.log.

Actions #16

Updated by Aishwarya Mathuria almost 2 years ago · Edited

/a/teuthology-2024-06-09_21:00:03-rados-squid-distro-default-smithi/7747180 - different test osd-erasure-code-profile.sh

2024-06-10T06:48:47.386 INFO:tasks.workunit.client.0.smithi121.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:61: TEST_set:  ceph osd erasure-code-profile set myprofile
2024-06-10T06:48:47.562 INFO:tasks.workunit.client.0.smithi121.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:62: TEST_set:  grep 'will not override' td/osd-erasure-code-profile/out
2024-06-10T06:48:47.563 INFO:tasks.workunit.client.0.smithi121.stdout:Error EPERM: will not override erasure code profile myprofile because the existing profile {crush-device-class=,crush-failure-domain=host,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,k=7,key=value,m=3,plugin=isa,technique=reed_sol_van} is different from the proposed profile {crush-device-class=,crush-failure-domain=host,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,jerasure-per-chunk-alignment=false,k=2,m=2,plugin=jerasure,technique=reed_sol_van,w=8}
2024-06-10T06:48:47.564 INFO:tasks.workunit.client.0.smithi121.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:63: TEST_set:  ceph osd erasure-code-profile set myprofile key=other --force
2024-06-10T06:48:47.778 INFO:tasks.workunit.client.0.smithi121.stderr:Error EPERM: overriding erasure code profile can be DANGEROUS; add --yes-i-really-mean-it to do it anyway
Actions #17

Updated by Laura Flores almost 2 years ago

Note from bug scrub: bump up to get tested in QA.

Actions #18

Updated by Aishwarya Mathuria over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
Actions #19

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #66690: squid: Overriding an EC pool needs the "--yes-i-really-mean-it" flag in addition to "force" added
Actions #20

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #66691: reef: Overriding an EC pool needs the "--yes-i-really-mean-it" flag in addition to "force" added
Actions #21

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions #22

Updated by Laura Flores over 1 year ago

/a/yuriw-2024-06-27_20:00:00-rados-squid-release-distro-default-smithi/7776824

Actions #23

Updated by Radoslaw Zarzynski over 1 year ago

  • Subtask #66611 added
Actions #24

Updated by Aishwarya Mathuria over 1 year ago

/a/yuriw-2024-08-07_21:27:43-rados-wip-yuri2-testing-2024-08-05-1243-reef-distro-default-smithi/7842760

Actions #25

Updated by Aishwarya Mathuria over 1 year ago · Edited

/a/yuriw-2024-08-14_00:34:25-rados-wip-yuri8-testing-2024-08-12-1457-reef-distro-default-smithi/7854111/
and 7854105,7854114,7854089,7854099,7854093

Actions #26

Updated by Laura Flores over 1 year ago

/a/yuriw-2024-08-09_22:43:18-rados-wip-yuri2-testing-2024-08-09-0834-reef-distro-default-smithi/7846607

Actions #27

Updated by Laura Flores over 1 year ago

/a/yuriw-2024-08-14_14:19:46-rados-wip-yuri6-testing-2024-08-13-1148-reef-distro-default-smithi/7855662

Actions #28

Updated by Samuel Just over 1 year ago

  • Has duplicate Bug #67754: rados: cannot update profile with --force and --yes-i-really-mean-it added
Actions #29

Updated by Konstantin Shalygin over 1 year ago

  • Status changed from Pending Backport to Resolved
  • Target version set to v20.0.0
  • Source set to Development
Actions #30

Updated by Shraddha Agrawal over 1 year ago

I see this error in QA for reef. Added a comment in the reef backport tracker: https://tracker.ceph.com/issues/66691#note-4.

Actions #31

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to f939c35f0515eca7d77a88c8ba32487724f5d7fe
  • Fixed In set to v19.3.0-2989-gf939c35f051
  • Upkeep Timestamp set to 2025-07-11T13:50:34+00:00
Actions #32

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-2989-gf939c35f051 to v19.3.0-2989-gf939c35f05
  • Upkeep Timestamp changed from 2025-07-11T13:50:34+00:00 to 2025-07-14T23:09:53+00:00
Actions #33

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~2623
  • Upkeep Timestamp changed from 2025-07-14T23:09:53+00:00 to 2025-11-01T01:33:57+00:00
Actions

Also available in: Atom PDF