Conversation
| :Description: Override an existing profile by the same name, and allow | ||
| setting a non-4K-aligned stripe_unit. | ||
| setting a non-4K-aligned stripe_unit. The former can be | ||
| dangerous, and thus ``--yes-i-really-mean-it`` must be |
There was a problem hiding this comment.
s/must be/must be used/
or
s/must be/must be invoked/
There was a problem hiding this comment.
Suggest s/The former/This/
There was a problem hiding this comment.
The intention was call dangerous just the overriding of existing, not setting an exotic stripe size.
There was a problem hiding this comment.
I suggest /The former/Overriding an existing profile/
2c2aae5 to
d967b49
Compare
This is per https://tracker.ceph.com/issues/64333#note-17 describing driving factors of a catastrophic cluster failure. Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
d967b49 to
629ba7b
Compare
|
jenkins test api |
jdurgin
left a comment
There was a problem hiding this comment.
talking to radek, we did see a couple niche valid uses of changing a ec profile - switching from one plugin to another with the same encoding scheme (e.g. jerasure to isa for reed solomon) and possibly other parameter updates that don't affect on-disk format for other plugins. So I'm ok with keeping the command, and requiring extra confirmation.
|
Looks like this PR was merged a little early- there is some fallout in teuthology. @rzarzynski FYI |
This is per https://tracker.ceph.com/issues/64333#note-17 describing driving factors of a catastrophic cluster failure.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e