Project

General

Profile

Actions
Copy link

Bug #64646

open

ceph osd pool rmsnap clone object leak

Added by Matan Breizman about 2 years ago. Updated 5 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Matan Breizman
Category:
Snapshots
Target version:
-
% Done:

0%

Source:
Backport:
quincy,reef,squid
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
55841
Tags (freeform):
Merge Commit:
c1e6f351450062a760c34fa936fdea76e284cd20
Fixed In:
v19.3.0-693-gc1e6f35145
Released In:
v20.2.0~3310
Upkeep Timestamp:
2025-11-01T00:55:23+00:00

Description

There are 2 ways to remove pool snaps, rados tool or mon command (ceph osd pool rmsnap).
It seems that the monitor command is not reporting the actual removal via new_removed_snaps which is later proceed in OSDMap::apply_incremental.
This will result in a clone object leakage since the snap id won't be marked as purged (and won't be trimmed).

First step (https://github.com/ceph/ceph/pull/55841) would be to fix the command.

Second step is to handle already leaked snapids which were impacted by the faulty command https://github.com/ceph/ceph/pull/57548.

Related issues 4 (2 open — 2 closed)

Precedes RADOS - Bug #66122: MON: Add force-remove-snap commandResolvedMatan Breizman

Actions
Copied to RADOS - Backport #65095: quincy: ceph osd pool rmsnap clone object leakResolvedMatan BreizmanActions
Copied to RADOS - Backport #65096: reef: ceph osd pool rmsnap clone object leakIn ProgressMatan BreizmanActions
Copied to RADOS - Backport #65097: squid: ceph osd pool rmsnap clone object leakIn ProgressMatan BreizmanActions
Actions
Copy link
 #1

Updated by Matan Breizman about 2 years ago

  • Pull request ID set to 55841
Actions
Copy link
 #2

Updated by Radoslaw Zarzynski about 2 years ago

note from bug scrub: reviewed, went to QA.

Actions
Copy link
 #3

Updated by Matan Breizman about 2 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Matan Breizman about 2 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Radoslaw Zarzynski about 2 years ago

  • Backport changed from quincy,reef to quincy,reef,squid

Need a squid backport as well.

Actions
Copy link
 #6

Updated by Matan Breizman about 2 years ago

Radoslaw Zarzynski wrote:

Need a squid backport as well.

Awaiting main merge (https://github.com/ceph/ceph/pull/55841)

Actions
Copy link
 #7

Updated by Radoslaw Zarzynski about 2 years ago

In QA.

Actions
Copy link
 #8

Updated by Matan Breizman almost 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #9

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #65095: quincy: ceph osd pool rmsnap clone object leak added
Actions
Copy link
 #10

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #65096: reef: ceph osd pool rmsnap clone object leak added
Actions
Copy link
 #11

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #65097: squid: ceph osd pool rmsnap clone object leak added
Actions
Copy link
 #13

Updated by Matan Breizman almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #14

Updated by Matan Breizman almost 2 years ago

  • Precedes Bug #66122: MON: Add force-remove-snap command added
Actions
Copy link
 #15

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to c1e6f351450062a760c34fa936fdea76e284cd20
  • Fixed In set to v19.3.0-693-gc1e6f351450
  • Upkeep Timestamp set to 2025-07-09T14:05:08+00:00
Actions
Copy link
 #16

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-693-gc1e6f351450 to v19.3.0-693-gc1e6f35145
  • Upkeep Timestamp changed from 2025-07-09T14:05:08+00:00 to 2025-07-14T17:41:14+00:00
Actions
Copy link
 #17

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~3310
  • Upkeep Timestamp changed from 2025-07-14T17:41:14+00:00 to 2025-11-01T00:55:23+00:00
Actions
Copy link

Also available in: Atom PDF