mon/OSDMonitor: Add force-remove-snap mon command#57548
Merged
Conversation
14 tasks
```
* Forces removal of snapshots in the range of
* [lower_snapid_bound, upper_snapid_bound) on pool <pool>
* in order to cause OSDs to re-trim them.
* The command has two mutually exclusive variants:
* * Default: All the snapids in the given range which are not
* marked as purged in the Monitor will be removed. Mostly useful
* for cases in which the snapid is leaked in the client side.
* See: https://tracker.ceph.com/issues/64646
```
Fixes: https://tracker.ceph.com/issues/66122
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
1f14b88 to
6855b04
Compare
Contributor
Author
14 tasks
athanatos
approved these changes
May 20, 2024
Contributor
Contributor
|
jenkins test windows |
Contributor
|
@Matan-B pls merge when all checks passed |
|
Is this getting backported to quincy? ...hoping so... |
This was referenced Aug 22, 2024
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/66122
Possibly Fixes: https://tracker.ceph.com/issues/64519
Remove all snapids in the range which are not marked as purged.
Useful for leaks such as: https://tracker.ceph.com/issues/64646
Example usage:
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e