feat(node-resolve): Resolve js/jsx/mjs/cjs imports from TypeScript files#1498
Merged
NotWoods merged 1 commit intorollup:masterfrom May 30, 2023
meyfa:feat/node-resolve-ts
Merged
feat(node-resolve): Resolve js/jsx/mjs/cjs imports from TypeScript files#1498NotWoods merged 1 commit intorollup:masterfrom meyfa:feat/node-resolve-ts
NotWoods merged 1 commit intorollup:masterfrom
meyfa:feat/node-resolve-ts
Conversation
9 tasks
|
it is very import to support |
lukastaegert
approved these changes
May 23, 2023
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks for the really quick response, this looks exactly how I hoped it would go!
|
how the progress of this feature? |
Contributor
Author
|
@shellscape Since you reviewed #1454, maybe you could take a look at this PR as well? |
tada5hi
approved these changes
May 30, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #1465
Description
This patch is a combination of PRs #1475 and #1454. It updates the logic for importing from within a TypeScript file. In that case,
.jscan now resolve to.tsand.tsx,.jsxcan resolve to.tsx,.mjscan resolve to.mts, and.cjscan resolve to.cts. This behavior was verified to mimic that oftscitself. Importing from within plain JS files is untouched (e.g., a.jsimport from within a.jsfile will not resolve to.ts).