fix(node-resolve): Resolve all combinations of .ts/.tsx imported as .js#1475
Closed
meyfa wants to merge 1 commit intorollup:masterfrom
meyfa:fix/issue-1465
Closed
fix(node-resolve): Resolve all combinations of .ts/.tsx imported as .js#1475meyfa wants to merge 1 commit intorollup:masterfrom meyfa:fix/issue-1465
meyfa wants to merge 1 commit intorollup:masterfrom
meyfa:fix/issue-1465
Conversation
9 tasks
Member
9 tasks
Contributor
Author
|
@lukastaegert Done! See #1498 |
Contributor
Author
|
Closing this, since #1498 was merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #1465
Description
When importing a file ending in
.jsfrom a TypeScript file (extension.tsor.tsx), this should resolve to both.tsor
.tsx. Before this patch,.tsxwould only be resolved when the importing file was itself a.tsx, and the same for.ts. This behavior was contrary to the existing comment above the check.