Round box position to integer when pasting embedded color#6517
Merged
hugovk merged 4 commits intopython-pillow:mainfrom Oct 11, 2022
Merged
Round box position to integer when pasting embedded color#6517hugovk merged 4 commits intopython-pillow:mainfrom
hugovk merged 4 commits intopython-pillow:mainfrom
Conversation
Contributor
|
I've created radarhere#18 with a few suggestions. |
nulano
approved these changes
Aug 25, 2022
Contributor
nulano
left a comment
There was a problem hiding this comment.
The alternative image is for Centos 7, for some reason the Codecov processing failed for that one coverage report:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6515
If
align="center"is used formultiline_text,Pillow/src/PIL/ImageDraw.py
Lines 562 to 570 in 4c59f77
then
coordcan be a float for theembedded_colorpaste. But when pasting one image onto another, the co-ordinates must be integers, and so an error will be raised, as in the issue.Pillow/src/PIL/ImageDraw.py
Line 486 in 4c59f77
This PR rounds the co-ordinates to integers in that case.