Skip to content

Simplify code and test#18

Merged
radarhere merged 1 commit intoradarhere:multiline_centered_embedded_colorfrom
nulano:float_text_coord
Aug 25, 2022
Merged

Simplify code and test#18
radarhere merged 1 commit intoradarhere:multiline_centered_embedded_colorfrom
nulano:float_text_coord

Conversation

@nulano
Copy link
Copy Markdown

@nulano nulano commented Aug 24, 2022

For python-pillow#6517

Changes proposed in this pull request:

  • Slightly simplify coord rounding.
  • While multiline text might be what caused the issue report, I'd suggest explicitly passing float coords to the text function. This can also be tested for all font modes.
  • While testing, I found that the test_standard_embedded_color epsilon can now be decreased.

@radarhere radarhere merged commit 18bd77b into radarhere:multiline_centered_embedded_color Aug 25, 2022
@nulano nulano deleted the float_text_coord branch August 25, 2022 12:38
radarhere added a commit that referenced this pull request Feb 3, 2025
* Removed skip_unless_feature on methods when class is already skipped

* Test speed less than slowest and greater than fastest

* Updated type hints

* Only access angle when AVIF_TRANSFORM_IROT flag is present

* Added AVIF_ROOT

* Only define normalize_quantize_value if it will be used

* Build libavif after libjpeg

* Use rgb.rowBytes in overflow check

* Group EXIF info

* Removed __loaded

* If brew is not installed, use /usr prefix

* Sort AVIF codecs alphabetically

* Updated rav1e license

* Fixed catching warning, as per python-pillow#8505

* Simplified code

* Fixed typos

* Test further scenarios

* Use y* to parse bytes

---------

Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants