Do not prematurely return in ImageFile when saving to stdout#5665
Merged
radarhere merged 4 commits intopython-pillow:mainfrom Nov 25, 2021
Merged
Do not prematurely return in ImageFile when saving to stdout#5665radarhere merged 4 commits intopython-pillow:mainfrom
radarhere merged 4 commits intopython-pillow:mainfrom
Conversation
Member
|
When I try this, it doesn't fix the issue for me. Could you add a test to demonstrate? |
Contributor
Author
|
Added tests for JPEG and PPM formats. |
radarhere
reviewed
Aug 20, 2021
radarhere
reviewed
Aug 20, 2021
Member
|
This is reverting part of #1365. That PR added Looking back now, I think that was incorrect for this reason, that it did prevent the body of the image from being output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5657.
The removed block of code is bad for the following reasons: