Fixed PSDraw stdout Python 3 compatibility#1365
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Jul 31, 2015
Merged
Conversation
hugovk
added a commit
that referenced
this pull request
Jul 31, 2015
Fixed PSDraw stdout Python 3 compatibility
Member
|
Thanks. |
temaxter
added a commit
to temaxter/Pillow
that referenced
this pull request
Dec 1, 2017
Fix to issue python-pillow#1365 breaks saving pbm files (possibly other types?) to stdout with Python 2.7. Only the magic number and size rows are printed. New issue is fixed by testing Python version and not returning prematurely if version is < 3. Passes tests with both Python 2.7.12 and 3.5.2 (Ubuntu 16.04).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no file pointer is provided, PSDraw uses
sys.stdout. This causes some bugs in Python 3.To demonstrate, I've added a test.