Extend Counters, Summaries and Histograms with creation timestamp#1313
Merged
bwplotka merged 4 commits intoprometheus:mainfrom Sep 21, 2023
ArthurSens:created-timestamps
Merged
Extend Counters, Summaries and Histograms with creation timestamp#1313bwplotka merged 4 commits intoprometheus:mainfrom ArthurSens:created-timestamps
bwplotka merged 4 commits intoprometheus:mainfrom
ArthurSens:created-timestamps
Conversation
TheSpiritXIII
suggested changes
Jul 24, 2023
TheSpiritXIII
left a comment
There was a problem hiding this comment.
Good start! I'm going to have to research MetricVec myself...
bwplotka
reviewed
Jul 26, 2023
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! So far so good, @TheSpiritXIII comments are solid 👍🏽
Let's make sure that when OpenMetrics text format is used we DON'T create separate series unless instrumentation explicitly enable that in the promhttp config.
ArthurSens
commented
Jul 27, 2023
bwplotka
reviewed
Jul 31, 2023
Member
bwplotka
left a comment
There was a problem hiding this comment.
Looks good so far, some comments to make it even more correct and readable. Let me know if those make sense!
Thanks!
bwplotka
reviewed
Aug 2, 2023
dashpole
reviewed
Aug 2, 2023
bwplotka
reviewed
Aug 4, 2023
bwplotka
reviewed
Aug 4, 2023
bwplotka
reviewed
Aug 4, 2023
Member
bwplotka
left a comment
There was a problem hiding this comment.
Looks good so far, module some comments.
Member
Author
|
Thanks for all the reviews so far! @bwplotka, @TheSpiritXIII, @macxamin, it should be ready for another round of reviews :) |
bwplotka
reviewed
Aug 4, 2023
Merged
Member
Author
|
@kakkoyun, the PR should be basically ready! There is only one test that I can't figure out what it does and how to fix though 😢 When you have the time, could you take a look at TestHandler and provide any suggestions on how to fix it? |
bwplotka
reviewed
Aug 22, 2023
Member
bwplotka
left a comment
There was a problem hiding this comment.
Nice! Almost there. Is test handler still a problem? I can see tests passed?
Member
Author
I've shared it with Kemal on slack and forgot to post it here... I made changes to make the test pass, but I honestly don't understand what is being tested there. It would be nice if someone could double check if what I added makes sense or if I'm just hacking some way to make the test pass 😬 |
Member
Author
|
Thanks for all the suggestions again bartek! I agree it looks ugly to have duplicated I've also realized that I'm still not updating CreatedTimestamps when Histograms are reset. I'm hoping this could be done in a separate PR though 😅 |
bwplotka
approved these changes
Sep 20, 2023
Member
bwplotka
left a comment
There was a problem hiding this comment.
It needs rebase, otherwise LGTM! 💪🏽
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Changes: * Comments for "now" are more explicit and not inlined. * populateMetrics is simpler and bit more efficient without timestamp to time to timestamp conversionts for more common code. * Test consistency and simplicity - the fewer variables the better. * Fixed inconsistency for v2 and MetricVec - let's pass opt.now consistently. * We don't need TestCounterXXXTimestamp - we test CT in many other places already. * Added more involved test for counter vectors with created timestamp. * Refactored normalization for simplicity. * Make histogram, summaries now consistent. * Simplified histograms CT flow and implemented proper CT on reset. TODO for next PRs: * NewConstSummary and NewConstHistogram - ability to specify CTs there. Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Member
Author
|
The failing test seems to be unrelated, but I'm not sure 🤨 |
Member
|
It's fixed here #1348, so your PR should be good to go! |
renovate Bot
referenced
this pull request
in open-feature/flagd
Sep 27, 2023
….0 (#939) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#​1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#​1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#​1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1293](https://togithub.com/prometheus/client_golang/pull/1293) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1297](https://togithub.com/prometheus/client_golang/pull/1297) - ci: define minimal permissions to GitHub workflows by [@​diogoteles08](https://togithub.com/diogoteles08) in [https://github.com/prometheus/client_golang/pull/1295](https://togithub.com/prometheus/client_golang/pull/1295) - Do not allocate memory when there's no constraints by [@​Okhoshi](https://togithub.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1296](https://togithub.com/prometheus/client_golang/pull/1296) - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1306](https://togithub.com/prometheus/client_golang/pull/1306) - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1307](https://togithub.com/prometheus/client_golang/pull/1307) - histogram: Enable detection of a native histogram without observations by [@​beorn7](https://togithub.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1314](https://togithub.com/prometheus/client_golang/pull/1314) - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1305](https://togithub.com/prometheus/client_golang/pull/1305) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1302](https://togithub.com/prometheus/client_golang/pull/1302) - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@​tigrato](https://togithub.com/tigrato) in [https://github.com/prometheus/client_golang/pull/1318](https://togithub.com/prometheus/client_golang/pull/1318) - Add missing tick "\`" in README by [@​ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [https://github.com/prometheus/client_golang/pull/1321](https://togithub.com/prometheus/client_golang/pull/1321) - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1320](https://togithub.com/prometheus/client_golang/pull/1320) - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1319](https://togithub.com/prometheus/client_golang/pull/1319) - docs: trivial grammar fixes to improve readability in promauto Godoc by [@​sengi](https://togithub.com/sengi) in [https://github.com/prometheus/client_golang/pull/1322](https://togithub.com/prometheus/client_golang/pull/1322) - Add Go 1.21 support by [@​kakkoyun](https://togithub.com/kakkoyun) in [https://github.com/prometheus/client_golang/pull/1325](https://togithub.com/prometheus/client_golang/pull/1325) - Bump client_model by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1323](https://togithub.com/prometheus/client_golang/pull/1323) - histogram docs: Fixed minor nit. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1324](https://togithub.com/prometheus/client_golang/pull/1324) - Update building by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1326](https://togithub.com/prometheus/client_golang/pull/1326) - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1331](https://togithub.com/prometheus/client_golang/pull/1331) - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1329](https://togithub.com/prometheus/client_golang/pull/1329) - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1328](https://togithub.com/prometheus/client_golang/pull/1328) - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1284](https://togithub.com/prometheus/client_golang/pull/1284) - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1330](https://togithub.com/prometheus/client_golang/pull/1330) - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1304](https://togithub.com/prometheus/client_golang/pull/1304) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1332](https://togithub.com/prometheus/client_golang/pull/1332) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1338](https://togithub.com/prometheus/client_golang/pull/1338) - Cleanup golangci-lint errcheck by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1339](https://togithub.com/prometheus/client_golang/pull/1339) - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1348](https://togithub.com/prometheus/client_golang/pull/1348) - Extend Counters, Summaries and Histograms with creation timestamp by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1313](https://togithub.com/prometheus/client_golang/pull/1313) - Fix typos in comments, tests, and errors by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1346](https://togithub.com/prometheus/client_golang/pull/1346) - Deprecated comment should begin with "Deprecated:" by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1347](https://togithub.com/prometheus/client_golang/pull/1347) - Add changelog entry for 1.17 by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1352](https://togithub.com/prometheus/client_golang/pull/1352) </details> #### New Contributors * @​diogoteles08 made their first contributi[https://github.com/prometheus/client_golang/pull/1295](https://togithub.com/prometheus/client_golang/pull/1295)l/1295 * @​tigrato made their first contributi[https://github.com/prometheus/client_golang/pull/1318](https://togithub.com/prometheus/client_golang/pull/1318)l/1318 * @​ZiViZiViZ made their first contributi[https://github.com/prometheus/client_golang/pull/1321](https://togithub.com/prometheus/client_golang/pull/1321)l/1321 * @​sengi made their first contributi[https://github.com/prometheus/client_golang/pull/1322](https://togithub.com/prometheus/client_golang/pull/1322)l/1322 * @​ArthurSens made their first contributi[https://github.com/prometheus/client_golang/pull/1323](https://togithub.com/prometheus/client_golang/pull/1323)l/1323 * @​alexandear made their first contributi[https://github.com/prometheus/client_golang/pull/1348](https://togithub.com/prometheus/client_golang/pull/1348)l/1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
apricote
referenced
this pull request
in hetznercloud/hcloud-cloud-controller-manager
Sep 28, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#​1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#​1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#​1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1293](https://togithub.com/prometheus/client_golang/pull/1293) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1297](https://togithub.com/prometheus/client_golang/pull/1297) - ci: define minimal permissions to GitHub workflows by [@​diogoteles08](https://togithub.com/diogoteles08) in [https://github.com/prometheus/client_golang/pull/1295](https://togithub.com/prometheus/client_golang/pull/1295) - Do not allocate memory when there's no constraints by [@​Okhoshi](https://togithub.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1296](https://togithub.com/prometheus/client_golang/pull/1296) - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1306](https://togithub.com/prometheus/client_golang/pull/1306) - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1307](https://togithub.com/prometheus/client_golang/pull/1307) - histogram: Enable detection of a native histogram without observations by [@​beorn7](https://togithub.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1314](https://togithub.com/prometheus/client_golang/pull/1314) - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1305](https://togithub.com/prometheus/client_golang/pull/1305) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1302](https://togithub.com/prometheus/client_golang/pull/1302) - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@​tigrato](https://togithub.com/tigrato) in [https://github.com/prometheus/client_golang/pull/1318](https://togithub.com/prometheus/client_golang/pull/1318) - Add missing tick "\`" in README by [@​ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [https://github.com/prometheus/client_golang/pull/1321](https://togithub.com/prometheus/client_golang/pull/1321) - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1320](https://togithub.com/prometheus/client_golang/pull/1320) - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1319](https://togithub.com/prometheus/client_golang/pull/1319) - docs: trivial grammar fixes to improve readability in promauto Godoc by [@​sengi](https://togithub.com/sengi) in [https://github.com/prometheus/client_golang/pull/1322](https://togithub.com/prometheus/client_golang/pull/1322) - Add Go 1.21 support by [@​kakkoyun](https://togithub.com/kakkoyun) in [https://github.com/prometheus/client_golang/pull/1325](https://togithub.com/prometheus/client_golang/pull/1325) - Bump client_model by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1323](https://togithub.com/prometheus/client_golang/pull/1323) - histogram docs: Fixed minor nit. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1324](https://togithub.com/prometheus/client_golang/pull/1324) - Update building by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1326](https://togithub.com/prometheus/client_golang/pull/1326) - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1331](https://togithub.com/prometheus/client_golang/pull/1331) - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1329](https://togithub.com/prometheus/client_golang/pull/1329) - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1328](https://togithub.com/prometheus/client_golang/pull/1328) - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1284](https://togithub.com/prometheus/client_golang/pull/1284) - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1330](https://togithub.com/prometheus/client_golang/pull/1330) - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1304](https://togithub.com/prometheus/client_golang/pull/1304) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1332](https://togithub.com/prometheus/client_golang/pull/1332) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1338](https://togithub.com/prometheus/client_golang/pull/1338) - Cleanup golangci-lint errcheck by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1339](https://togithub.com/prometheus/client_golang/pull/1339) - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1348](https://togithub.com/prometheus/client_golang/pull/1348) - Extend Counters, Summaries and Histograms with creation timestamp by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1313](https://togithub.com/prometheus/client_golang/pull/1313) - Fix typos in comments, tests, and errors by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1346](https://togithub.com/prometheus/client_golang/pull/1346) - Deprecated comment should begin with "Deprecated:" by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1347](https://togithub.com/prometheus/client_golang/pull/1347) - Add changelog entry for 1.17 by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1352](https://togithub.com/prometheus/client_golang/pull/1352) </details> #### New Contributors * @​diogoteles08 made their first contributi[https://github.com/prometheus/client_golang/pull/1295](https://togithub.com/prometheus/client_golang/pull/1295)l/1295 * @​tigrato made their first contributi[https://github.com/prometheus/client_golang/pull/1318](https://togithub.com/prometheus/client_golang/pull/1318)l/1318 * @​ZiViZiViZ made their first contributi[https://github.com/prometheus/client_golang/pull/1321](https://togithub.com/prometheus/client_golang/pull/1321)l/1321 * @​sengi made their first contributi[https://github.com/prometheus/client_golang/pull/1322](https://togithub.com/prometheus/client_golang/pull/1322)l/1322 * @​ArthurSens made their first contributi[https://github.com/prometheus/client_golang/pull/1323](https://togithub.com/prometheus/client_golang/pull/1323)l/1323 * @​alexandear made their first contributi[https://github.com/prometheus/client_golang/pull/1348](https://togithub.com/prometheus/client_golang/pull/1348)l/1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/hcloud-cloud-controller-manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nono
referenced
this pull request
in cozy/cozy-stack
Oct 2, 2023
….0 (#4144) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#​1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#​1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#​1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1293](https://togithub.com/prometheus/client_golang/pull/1293) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1297](https://togithub.com/prometheus/client_golang/pull/1297) - ci: define minimal permissions to GitHub workflows by [@​diogoteles08](https://togithub.com/diogoteles08) in [https://github.com/prometheus/client_golang/pull/1295](https://togithub.com/prometheus/client_golang/pull/1295) - Do not allocate memory when there's no constraints by [@​Okhoshi](https://togithub.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1296](https://togithub.com/prometheus/client_golang/pull/1296) - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1306](https://togithub.com/prometheus/client_golang/pull/1306) - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1307](https://togithub.com/prometheus/client_golang/pull/1307) - histogram: Enable detection of a native histogram without observations by [@​beorn7](https://togithub.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1314](https://togithub.com/prometheus/client_golang/pull/1314) - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1305](https://togithub.com/prometheus/client_golang/pull/1305) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1302](https://togithub.com/prometheus/client_golang/pull/1302) - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@​tigrato](https://togithub.com/tigrato) in [https://github.com/prometheus/client_golang/pull/1318](https://togithub.com/prometheus/client_golang/pull/1318) - Add missing tick "\`" in README by [@​ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [https://github.com/prometheus/client_golang/pull/1321](https://togithub.com/prometheus/client_golang/pull/1321) - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1320](https://togithub.com/prometheus/client_golang/pull/1320) - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1319](https://togithub.com/prometheus/client_golang/pull/1319) - docs: trivial grammar fixes to improve readability in promauto Godoc by [@​sengi](https://togithub.com/sengi) in [https://github.com/prometheus/client_golang/pull/1322](https://togithub.com/prometheus/client_golang/pull/1322) - Add Go 1.21 support by [@​kakkoyun](https://togithub.com/kakkoyun) in [https://github.com/prometheus/client_golang/pull/1325](https://togithub.com/prometheus/client_golang/pull/1325) - Bump client_model by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1323](https://togithub.com/prometheus/client_golang/pull/1323) - histogram docs: Fixed minor nit. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1324](https://togithub.com/prometheus/client_golang/pull/1324) - Update building by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1326](https://togithub.com/prometheus/client_golang/pull/1326) - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1331](https://togithub.com/prometheus/client_golang/pull/1331) - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1329](https://togithub.com/prometheus/client_golang/pull/1329) - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1328](https://togithub.com/prometheus/client_golang/pull/1328) - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1284](https://togithub.com/prometheus/client_golang/pull/1284) - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1330](https://togithub.com/prometheus/client_golang/pull/1330) - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1304](https://togithub.com/prometheus/client_golang/pull/1304) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1332](https://togithub.com/prometheus/client_golang/pull/1332) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/client_golang/pull/1338](https://togithub.com/prometheus/client_golang/pull/1338) - Cleanup golangci-lint errcheck by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1339](https://togithub.com/prometheus/client_golang/pull/1339) - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1348](https://togithub.com/prometheus/client_golang/pull/1348) - Extend Counters, Summaries and Histograms with creation timestamp by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1313](https://togithub.com/prometheus/client_golang/pull/1313) - Fix typos in comments, tests, and errors by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1346](https://togithub.com/prometheus/client_golang/pull/1346) - Deprecated comment should begin with "Deprecated:" by [@​alexandear](https://togithub.com/alexandear) in [https://github.com/prometheus/client_golang/pull/1347](https://togithub.com/prometheus/client_golang/pull/1347) - Add changelog entry for 1.17 by [@​ArthurSens](https://togithub.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1352](https://togithub.com/prometheus/client_golang/pull/1352) </details> #### New Contributors * @​diogoteles08 made their first contributi[https://github.com/prometheus/client_golang/pull/1295](https://togithub.com/prometheus/client_golang/pull/1295)l/1295 * @​tigrato made their first contributi[https://github.com/prometheus/client_golang/pull/1318](https://togithub.com/prometheus/client_golang/pull/1318)l/1318 * @​ZiViZiViZ made their first contributi[https://github.com/prometheus/client_golang/pull/1321](https://togithub.com/prometheus/client_golang/pull/1321)l/1321 * @​sengi made their first contributi[https://github.com/prometheus/client_golang/pull/1322](https://togithub.com/prometheus/client_golang/pull/1322)l/1322 * @​ArthurSens made their first contributi[https://github.com/prometheus/client_golang/pull/1323](https://togithub.com/prometheus/client_golang/pull/1323)l/1323 * @​alexandear made their first contributi[https://github.com/prometheus/client_golang/pull/1348](https://togithub.com/prometheus/client_golang/pull/1348)l/1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
Oct 3, 2023
Particularly to bring in a performance fix prometheus/client_golang#1296. Most changes are fixing spelling or punctuation in spelling, but there is also the addition of creation timestamps from prometheus/client_golang#1313.
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
Oct 3, 2023
Particularly to bring in a performance fix prometheus/client_golang#1296. Most changes are fixing spelling or punctuation in spelling, but there is also the addition of creation timestamps from prometheus/client_golang#1313.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following our design doc, this PR aims to add created timestamp to counters, summaries, and histograms when using Prometheus protobuf.