[docs-infra] Improve support for absolute locale URL#40940
Merged
oliviertassinari merged 1 commit intomui:masterfrom Feb 5, 2024
Merged
[docs-infra] Improve support for absolute locale URL#40940oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari merged 1 commit intomui:masterfrom
Conversation
f7907ea to
1fa30e6
Compare
Netlify deploy previewhttps://deploy-preview-40940--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Feb 5, 2024
1 task
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Feb 6, 2024
Member
Author
|
The change is now in production. Tested, it actually works 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm reverting a change we did in #18441 to support Next.js v9. The underlying issue has since been solved in https://github.com/vercel/next.js/pull/15792/files#diff-29e1b9bc8e17f47fa46cad2f0e0e54d5bbb268adee26051c21d929902a2a5c8cR69 by @Janpot
To get the value of this change see https://mui.com/careers/react-engineer-x-charts/#benefits-and-compensation how the
https://mui.com/careers/#perks-and-benefitslink triggers a full page navigation:Screen.Recording.2024-02-04.at.21.11.39.mov
I noticed this from #40890 (comment).