Skip to content

[docs] Upgrade to next 9#18441

Merged
eps1lon merged 18 commits intomui:masterfrom
eps1lon:docs/next-9
Mar 4, 2020
Merged

[docs] Upgrade to next 9#18441
eps1lon merged 18 commits intomui:masterfrom
eps1lon:docs/next-9

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 18, 2019 •
edited
Loading

Preview: https://deploy-preview-18441--material-ui.netlify.com/

  • /api moves to /api-docs to not be considered an API route. Via rewrites we keep the URLs
  • /static is deprecated in favor of /public
    We can use this to move the /cdn into /public. I didn't touch the static paths since this affects some 300 files some of which are translated.
  • Container is deprecated so I removed it
  • fixup bundle size tracking of landing page
  • how to reproduce bad transpilation
  • netlify build time looks the same, azure took 2-3 minutes longer though (would take 10minutes more build time there TBH)

Future work

  • reintroduce (and change approach) page size tracking
  • investigate if we can remove the custom server.js by using rewrites for i18n Done

@eps1lon eps1lon added docs Improvements or additions to the documentation. performance labels Nov 18, 2019
eps1lon
eps1lon commented Nov 18, 2019
View reviewed changes
@eps1lon eps1lon mentioned this pull request Nov 19, 2019
Closed
6 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 19, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 05c992e...67d1327

bundle Size Change Size Gzip Change Gzip
docs.landing ▼ -2.26 kB (-3.99% ) 54.4 kB ▲ +47 B (+0.30% ) 15.7 kB
docs.main ▼ -1.2 kB (-0.20% ) 601 kB ▲ +1.32 kB (+0.68% ) 197 kB
@material-ui/core -- 359 kB -- 98.8 kB
@material-ui/core[umd] -- 318 kB -- 92.1 kB
@material-ui/lab -- 199 kB -- 58.9 kB
@material-ui/styles -- 51.4 kB -- 15.4 kB
@material-ui/system -- 16.5 kB -- 4.31 kB
Alert -- 86.6 kB -- 27.3 kB
AlertTitle -- 67.5 kB -- 21.2 kB
AppBar -- 67.4 kB -- 21.1 kB
Autocomplete -- 134 kB -- 42.2 kB
Avatar -- 68.5 kB -- 21.7 kB
AvatarGroup -- 65.7 kB -- 20.6 kB
Backdrop -- 71.2 kB -- 22 kB
Badge -- 68.7 kB -- 21.3 kB
BottomNavigation -- 65.7 kB -- 20.6 kB
BottomNavigationAction -- 78.8 kB -- 24.9 kB
Box -- 72.3 kB -- 21.8 kB
Breadcrumbs -- 83.6 kB -- 26.5 kB
Button -- 83 kB -- 25.4 kB
ButtonBase -- 77.3 kB -- 24.2 kB
ButtonGroup -- 86.5 kB -- 26.6 kB
Card -- 66.2 kB -- 20.7 kB
CardActionArea -- 78.4 kB -- 24.8 kB
CardActions -- 65.4 kB -- 20.5 kB
CardContent -- 65.3 kB -- 20.4 kB
CardHeader -- 68.4 kB -- 21.5 kB
CardMedia -- 65.7 kB -- 20.6 kB
Checkbox -- 85.4 kB -- 27 kB
Chip -- 85.8 kB -- 26.3 kB
CircularProgress -- 67.4 kB -- 21.2 kB
ClickAwayListener -- 3.84 kB -- 1.54 kB
Collapse -- 71.3 kB -- 22.1 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 66.5 kB -- 20.8 kB
CssBaseline -- 65.3 kB -- 20.5 kB
Dialog -- 86.2 kB -- 26.9 kB
DialogActions -- 65.4 kB -- 20.5 kB
DialogContent -- 65.6 kB -- 20.5 kB
DialogContentText -- 67.4 kB -- 21.1 kB
DialogTitle -- 67.6 kB -- 21.2 kB
Divider -- 66 kB -- 20.7 kB
Drawer -- 87.9 kB -- 26.8 kB
ExpansionPanel -- 74.9 kB -- 23.5 kB
ExpansionPanelActions -- 65.4 kB -- 20.5 kB
ExpansionPanelDetails -- 65.3 kB -- 20.4 kB
ExpansionPanelSummary -- 81.4 kB -- 25.7 kB
Fab -- 80.1 kB -- 24.9 kB
Fade -- 27.1 kB -- 9.05 kB
FilledInput -- 76.9 kB -- 23.9 kB
FormControl -- 67.7 kB -- 21.1 kB
FormControlLabel -- 68.8 kB -- 21.6 kB
FormGroup -- 65.4 kB -- 20.5 kB
FormHelperText -- 66.7 kB -- 20.7 kB
FormLabel -- 66.8 kB -- 20.7 kB
Grid -- 68.4 kB -- 21.4 kB
GridList -- 65.8 kB -- 20.6 kB
GridListTile -- 67.1 kB -- 21 kB
GridListTileBar -- 66.6 kB -- 20.8 kB
Grow -- 27.7 kB -- 9.26 kB
Hidden -- 69.3 kB -- 21.7 kB
Icon -- 66.1 kB -- 20.7 kB
IconButton -- 79.4 kB -- 24.8 kB
Input -- 75.9 kB -- 23.7 kB
InputAdornment -- 68.4 kB -- 21.6 kB
InputBase -- 74 kB -- 23.2 kB
InputLabel -- 68.6 kB -- 21.2 kB
LinearProgress -- 68.7 kB -- 21.2 kB
Link -- 69.9 kB -- 22.1 kB
List -- 65.7 kB -- 20.5 kB
ListItem -- 80.3 kB -- 25.1 kB
ListItemAvatar -- 65.4 kB -- 20.5 kB
ListItemIcon -- 65.5 kB -- 20.5 kB
ListItemSecondaryAction -- 65.4 kB -- 20.5 kB
ListItemText -- 68.3 kB -- 21.5 kB
ListSubheader -- 66.1 kB -- 20.8 kB
Menu -- 91.8 kB -- 28.3 kB
MenuItem -- 81.4 kB -- 25.4 kB
MenuList -- 69.3 kB -- 21.7 kB
MobileStepper -- 71.2 kB -- 22.3 kB
Modal -- 14.3 kB -- 5.04 kB
NativeSelect -- 80.1 kB -- 25.3 kB
NoSsr -- 2.17 kB -- 1.03 kB
OutlinedInput -- 77.9 kB -- 24.2 kB
Pagination -- 87.6 kB -- 27 kB
PaginationItem -- 84 kB -- 25.9 kB
Paper -- 65.7 kB -- 20.5 kB
Popover -- 86.2 kB -- 26.7 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 86.4 kB -- 27.3 kB
RadioGroup -- 67.1 kB -- 20.9 kB
Rating -- 73.7 kB -- 23.7 kB
RootRef -- 4.21 kB -- 1.64 kB
ScopedCssBaseline -- 66.2 kB -- 20.7 kB
Select -- 119 kB -- 35.3 kB
Skeleton -- 66.3 kB -- 20.9 kB
Slide -- 29.1 kB -- 9.78 kB
Slider -- 79.1 kB -- 25.2 kB
Snackbar -- 78.6 kB -- 24.5 kB
SnackbarContent -- 66.9 kB -- 21 kB
SpeedDial -- 89.4 kB -- 28.3 kB
SpeedDialAction -- 121 kB -- 38.4 kB
SpeedDialIcon -- 67.9 kB -- 21.3 kB
Step -- 66 kB -- 20.7 kB
StepButton -- 85.5 kB -- 27 kB
StepConnector -- 66.1 kB -- 20.8 kB
StepContent -- 72.5 kB -- 22.6 kB
StepIcon -- 67.9 kB -- 21.2 kB
StepLabel -- 71.9 kB -- 22.3 kB
Stepper -- 68.2 kB -- 21.5 kB
styles/createMuiTheme -- 20.9 kB -- 7.27 kB
SvgIcon -- 66.4 kB -- 20.7 kB
SwipeableDrawer -- 95.3 kB -- 29.9 kB
Switch -- 84.6 kB -- 26.6 kB
Tab -- 79.6 kB -- 25.3 kB
Table -- 65.9 kB -- 20.6 kB
TableBody -- 65.4 kB -- 20.5 kB
TableCell -- 67.4 kB -- 21.2 kB
TableContainer -- 65.3 kB -- 20.4 kB
TableFooter -- 65.5 kB -- 20.5 kB
TableHead -- 65.4 kB -- 20.5 kB
TablePagination -- 145 kB -- 42.6 kB
TableRow -- 65.8 kB -- 20.6 kB
TableSortLabel -- 80.6 kB -- 25.5 kB
Tabs -- 88.6 kB -- 28.3 kB
TextareaAutosize -- 5.19 kB -- 2.17 kB
TextField -- 127 kB -- 37.4 kB
ToggleButton -- 79.4 kB -- 25.1 kB
ToggleButtonGroup -- 66.5 kB -- 20.9 kB
Toolbar -- 65.7 kB -- 20.6 kB
Tooltip -- 105 kB -- 33.1 kB
TreeItem -- 78.5 kB -- 24.8 kB
TreeView -- 71.5 kB -- 22.4 kB
Typography -- 67 kB -- 20.9 kB
useAutocomplete -- 15 kB -- 5.4 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
Zoom -- 27.1 kB -- 9.18 kB

Generated by 🚫 dangerJS against 67d1327

oliviertassinari
oliviertassinari reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early overview while it's still in draft. Feel free to ignore it.

@eps1lon eps1lon force-pushed the docs/next-9 branch 2 times, most recently from 9a884c7 to fad482d Compare November 19, 2019 15:46
@eps1lon eps1lon added the on hold There is a blocker, we need to wait. label Nov 20, 2019
eps1lon
eps1lon commented Nov 20, 2019
View reviewed changes
@eps1lon eps1lon mentioned this pull request Nov 22, 2019
Open
This was referenced Dec 5, 2019
Closed
Closed
@oliviertassinari oliviertassinari mentioned this pull request Jan 4, 2020
Merged
1 task
@eps1lon eps1lon force-pushed the docs/next-9 branch 2 times, most recently from f3bf5a0 to 0a143b9 Compare January 15, 2020 06:59
@eps1lon eps1lon removed the on hold There is a blocker, we need to wait. label Mar 2, 2020
@eps1lon eps1lon marked this pull request as ready for review March 2, 2020 14:42
eps1lon
eps1lon commented Mar 2, 2020
View reviewed changes
docs/package.json
"material-table": "^1.50.0",
"material-ui-popup-state": "^1.4.1",
"next": "8.1.0",
"next": "9.1.4",
Copy link
Member Author

@eps1lon eps1lon Mar 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to latest stable next release in a follow-up since they changed how they polyfill.

@eps1lon eps1lon requested a review from oliviertassinari March 2, 2020 14:46
oliviertassinari
oliviertassinari reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I can spot on the live preview is the open side nav on the home page

oliviertassinari
oliviertassinari reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try to deploy the branch in production to see how that goes before merging?

@eps1lon
Copy link
Member Author

eps1lon commented Mar 2, 2020

The only issue I can spot on the live preview is the open side nav on the home page

Right forgot about that one. Will fix.

Should we try to deploy the branch in production to see how that goes before merging?

Not sure what you mean by production. It's already built for the production environment in the deploy previews.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 2, 2020

Right forgot about that one. Will fix.

Awesome, great work!

Not sure what you mean by production.

I had http://material-ui.com/ in mind. So I can run SEO crawlers and tests the locales (e.g. /zh/)

@eps1lon
Copy link
Member Author

eps1lon commented Mar 2, 2020

I had http://material-ui.com/ in mind. So I can run SEO crawlers and tests the locales (e.g. /zh/)

Why can't you do that with the deploy preview?

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 3, 2020

@eps1lon I have rebased to resolve the conflict with master, I hope it's fine with you. I think that it's good to land, feel free to merge when you are ready 🚀😄.

@eps1lon
Copy link
Member Author

eps1lon commented Mar 4, 2020

Let's see if this works.

@eps1lon eps1lon merged commit faca5c4 into mui:master Mar 4, 2020
@eps1lon eps1lon deleted the docs/next-9 branch March 4, 2020 09:56
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Mar 4, 2020
@eps1lon
[docs] Upgrade to next 9 (mui#18441)
64d73e2
This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@oliviertassinari oliviertassinari mentioned this pull request Mar 21, 2020
Closed
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@eps1lon @EsoterikStare
[docs] Upgrade to next 9 (mui#18441)
3349bc6
This was referenced Apr 10, 2020
Closed
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@iquabius iquabius mentioned this pull request Jun 13, 2020
Closed
This was referenced Feb 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

+1 more reviewer

@merceyz merceyz merceyz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Improvements or additions to the documentation. performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eps1lon @mui-pr-bot @oliviertassinari @merceyz