feat(spanner): support for type UUID #2482

alkatrivedi · 2025-12-10T10:34:53Z

This PR is to add support for type UUID.

gemini-code-assist · 2025-12-10T10:35:11Z

Summary of Changes

Hello @alkatrivedi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Spanner client library by adding full support for the UUID data type. It integrates UUID handling into the core codec, updates parameter binding mechanisms, and includes thorough testing to ensure reliability and correctness across different Spanner dialects. This feature allows developers to work with UUIDs natively within their applications when interacting with Spanner databases.

Highlights

UUID Type Support: Introduced comprehensive support for the UUID data type across the Spanner client library, enabling proper handling of UUID values in both Google Standard SQL and PostgreSQL dialects.
Codec Enhancements: Updated the internal codec to correctly identify, encode, and decode UUID values, ensuring seamless conversion between application data and Spanner's UUID type.
Parameter Binding Logic: Refined the parameter encoding logic to ensure that type objects are only created for explicitly defined types or for types that are not TYPE_CODE_UNSPECIFIED, improving type inference and handling.
Extensive Testing: Added a suite of unit and system tests to validate the new UUID functionality, covering insertion, querying, and parameter binding for both single UUIDs and arrays of UUIDs in various scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces support for the UUID data type in Spanner. The changes span across the codec for type handling, transaction logic for parameter encoding, and comprehensive additions to both unit and system tests. The approach for type inference is to let Spanner infer the type for UUID-like strings, which provides flexibility. The new tests are well-written and cover various scenarios. I've identified a couple of minor issues in the system tests where assertions for field counts were not updated, and a small inefficiency in the transaction processing logic. After addressing these points, the PR should be ready for merging.

gemini-code-assist · 2025-12-10T10:37:08Z

system-test/spanner.ts

+        assert.strictEqual(metadata.rowType!.fields![2].name, 'UUID');
+        assert.strictEqual(metadata.rowType!.fields![3].name, 'Float32');
+        assert.strictEqual(metadata.rowType!.fields![4].name, 'Float');
+        assert.strictEqual(metadata.rowType!.fields![5].name, 'Int');
+        assert.strictEqual(metadata.rowType!.fields![6].name, 'Info');
+        assert.strictEqual(metadata.rowType!.fields![7].name, 'Created');
+        assert.strictEqual(metadata.rowType!.fields![8].name, 'DOB');
+        assert.strictEqual(metadata.rowType!.fields![9].name, 'Accents');
+        assert.strictEqual(metadata.rowType!.fields![10].name, 'PhoneNumbers');
+        assert.strictEqual(metadata.rowType!.fields![11].name, 'HasGear');


While you've correctly updated the assertions for the field names, the assertion for the total number of fields on line 4252 is now incorrect. With the addition of the UUID column, the total number of fields is 12, but the test still asserts 11. Please update that line as well:

assert.strictEqual(metadata.rowType!.fields!.length, 12);

gemini-code-assist · 2025-12-10T10:37:08Z

system-test/spanner.ts

+        assert.strictEqual(metadata.rowType!.fields![2].name, 'UUID');
+        assert.strictEqual(metadata.rowType!.fields![3].name, 'Float32');
+        assert.strictEqual(metadata.rowType!.fields![4].name, 'Float');
+        assert.strictEqual(metadata.rowType!.fields![5].name, 'Int');
+        assert.strictEqual(metadata.rowType!.fields![6].name, 'Info');
+        assert.strictEqual(metadata.rowType!.fields![7].name, 'Created');
+        assert.strictEqual(metadata.rowType!.fields![8].name, 'HasGear');


Similar to the previous comment, the assertion for the total number of fields on line 4284 is now incorrect. With the addition of the UUID column, the total number of fields is 9, but the test still asserts 8. Please update that line as well:

assert.strictEqual(metadata.rowType!.fields!.length, 9);

gemini-code-assist · 2025-12-10T10:37:08Z

src/transaction.ts

+        const typeObject = codec.createTypeObject(type);
+        if (
+          (type.child &&
+            typeObject.code === 'ARRAY' &&
+            typeObject.arrayElementType?.code !== 'TYPE_CODE_UNSPECIFIED') ||
+          (!type.child && typeObject.code !== 'TYPE_CODE_UNSPECIFIED')
+        ) {
+          paramTypes[param] = codec.createTypeObject(type);
+        }


The codec.createTypeObject(type) function is called twice here, once to create typeObject for the if condition and then again inside the if block. This is inefficient. You can reuse the typeObject that was already created.

Suggested change

const typeObject = codec.createTypeObject(type);

if (

(type.child &&

typeObject.code === 'ARRAY' &&

typeObject.arrayElementType?.code !== 'TYPE_CODE_UNSPECIFIED') ||

(!type.child && typeObject.code !== 'TYPE_CODE_UNSPECIFIED')

) {

paramTypes[param] = codec.createTypeObject(type);

}

const typeObject = codec.createTypeObject(type);

if (

(type.child &&

typeObject.code === 'ARRAY' &&

typeObject.arrayElementType?.code !== 'TYPE_CODE_UNSPECIFIED') ||

(!type.child && typeObject.code !== 'TYPE_CODE_UNSPECIFIED')

) {

paramTypes[param] = typeObject;

}

generated-files-bot · 2025-12-15T11:29:18Z

Warning: This pull request is touching the following templated files:

.github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

surbhigarg92

Approving - The changes were already reviewed as part of #2235

alkatrivedi requested review from a team as code owners December 10, 2025 10:34

product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Dec 10, 2025

gemini-code-assist bot reviewed Dec 10, 2025

View reviewed changes

alkatrivedi force-pushed the uuid-type-support branch 2 times, most recently from 66a939f to 2708bba Compare December 10, 2025 11:16

alkatrivedi marked this pull request as draft December 10, 2025 11:23

alkatrivedi force-pushed the uuid-type-support branch 6 times, most recently from 2c56455 to ed0352a Compare December 16, 2025 10:24

feat(spanner): support for type UUID

c74d78c

alkatrivedi force-pushed the uuid-type-support branch from ed0352a to c74d78c Compare December 16, 2025 10:38

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2025

alkatrivedi marked this pull request as ready for review December 16, 2025 10:55

alkatrivedi mentioned this pull request Dec 16, 2025

feat(spanner): support for type UUID #2235

Closed

surbhigarg92 approved these changes Dec 16, 2025

View reviewed changes

alkatrivedi merged commit 0047e94 into main Dec 16, 2025
23 of 24 checks passed

alkatrivedi deleted the uuid-type-support branch December 16, 2025 11:44

release-please bot mentioned this pull request Dec 15, 2025

chore(main): release 8.4.0 #2473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(spanner): support for type UUID #2482

feat(spanner): support for type UUID #2482

Uh oh!

alkatrivedi commented Dec 10, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

generated-files-bot bot commented Dec 15, 2025

Uh oh!

surbhigarg92 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(spanner): support for type UUID #2482

feat(spanner): support for type UUID #2482

Uh oh!

Conversation

alkatrivedi commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 10, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

generated-files-bot bot commented Dec 15, 2025

Uh oh!

surbhigarg92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alkatrivedi commented Dec 10, 2025 •

edited

Loading