Skip to content

feat: Add autoscaling config in the instance to support autoscaling in systests #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harshachinta merged 11 commits into from
Dec 15, 2023
Merged

feat: Add autoscaling config in the instance to support autoscaling in systests #2756

harshachinta merged 11 commits into from
Dec 15, 2023

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 8, 2023 •
edited by harshachinta
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 589163292

Source-Link: googleapis/googleapis@03d2cc1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3a0a047f6d6fc88ee17cd71f9bf8e31802daf4f6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2EwYTA0N2Y2ZDZmYzg4ZWUxN2NkNzFmOWJmOGUzMTgwMmRhZjRmNiJ9

BEGIN_NESTED_COMMIT
chore: Update package name for gapic generated executor code
PiperOrigin-RevId: 589051885

Source-Link: googleapis/googleapis@90936c4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0b083b8384bd0ba7c8fe26320080d7a6c49af3ae
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIwODNiODM4NGJkMGJhN2M4ZmUyNjMyMDA4MGQ3YTZjNDlhZjNhZSJ9
END_NESTED_COMMIT

#######################################################################################

This PR additionally has the following manual changes,

  1. proto-google-cloud-spanner-executor-v1/
    1. clirr-ignored-differences.xml - CLIRR detects some class names are missing. This happened because of the change in class names from earlier com.google.spanner.executor.v1 to com.google.cloud.spanner.executor.v1 to maintain consistency with other classes in java-spanner repo.
    2. pom.xml - Add missed dependencies. Add unused dependencies to ignored.
  2. google-cloud-spanner-executor/pom.xml
    1. Add missing test dependencies and testing utility classes.
    2. Add missing grpc-protobuf dependency
    3. Add maven-dependency-plugin to ignore unused dependencies
  3. google-cloud-spanner/pom.xml
    1. Owl bot adds executor as a dependency to google-cloud-spanner. However, this is not the case and hence added them to list of ignored dependencies.
  4. grpc-google-cloud-spanner-executor-v1/pom.xml
    1. Add unused dependecies as part of ignored dependencies

@gcf-owl-bot
chore: Update package name for gapic generated executor code
782b7c6 
PiperOrigin-RevId: 589051885

Source-Link: googleapis/googleapis@90936c4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0b083b8384bd0ba7c8fe26320080d7a6c49af3ae
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIwODNiODM4NGJkMGJhN2M4ZmUyNjMyMDA4MGQ3YTZjNDlhZjNhZSJ9
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Dec 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 8, 2023 17:52
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners December 8, 2023 17:52
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@gcf-owl-bot
feat: Add autoscaling config in the instance to support autoscaling i…
831ede5 
…n systests

PiperOrigin-RevId: 589163292

Source-Link: googleapis/googleapis@03d2cc1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3a0a047f6d6fc88ee17cd71f9bf8e31802daf4f6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2EwYTA0N2Y2ZDZmYzg4ZWUxN2NkNzFmOWJmOGUzMTgwMmRhZjRmNiJ9
@gcf-owl-bot gcf-owl-bot bot changed the title chore: Update package name for gapic generated executor code feat: Add autoscaling config in the instance to support autoscaling in systests Dec 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@harshachinta harshachinta requested a review from arpan14 December 14, 2023 15:03
@harshachinta harshachinta merged commit 99ae565 into main Dec 15, 2023
@harshachinta harshachinta deleted the owl-bot-copy branch December 15, 2023 08:21
@release-please release-please bot mentioned this pull request Dec 12, 2023
Merged
@harshachinta harshachinta mentioned this pull request Dec 15, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 5, 2024
@release-please
chore(main): release 6.56.0 (#2755)
58f94b2 
🤖 I have created a release *beep* *boop*
---


## [6.56.0](https://togithub.com/googleapis/java-spanner/compare/v6.55.0...v6.56.0) (2024-01-05)


### Features

* Add autoscaling config in the instance to support autoscaling in systests ([#2756](https://togithub.com/googleapis/java-spanner/issues/2756)) ([99ae565](https://togithub.com/googleapis/java-spanner/commit/99ae565c5e90a2862b4f195fe64656ba8a05373d))
* Add support for Directed Read options ([#2766](https://togithub.com/googleapis/java-spanner/issues/2766)) ([26c6c63](https://togithub.com/googleapis/java-spanner/commit/26c6c634b685bce66ce7caf05057a98e9cc6f5dc))
* Update OwlBot.yaml file to pull autogenerated executor code ([#2754](https://togithub.com/googleapis/java-spanner/issues/2754)) ([20562d4](https://togithub.com/googleapis/java-spanner/commit/20562d4d7e62ab20bb1c4e78547b218a9a506f21))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.21.0 ([#2772](https://togithub.com/googleapis/java-spanner/issues/2772)) ([173f520](https://togithub.com/googleapis/java-spanner/commit/173f520f931073c4c6ddf3b3d98d255fb575914f))


### Documentation

* Samples and tests for auto-generated createDatabase and createInstance APIs. ([#2764](https://togithub.com/googleapis/java-spanner/issues/2764)) ([74a586f](https://togithub.com/googleapis/java-spanner/commit/74a586f8713ef742d65400da8f04a750316faf78))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arpan14 arpan14 arpan14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. owl-bot-copy size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arpan14 @yoshi-kokoro @harshachinta