Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: add a timeout on retry for retryable errors#1930

Merged
yirutang merged 12 commits into
googleapis:mainfrom
yirutang:stuck-fix
Jan 13, 2023
Merged

fix: add a timeout on retry for retryable errors#1930
yirutang merged 12 commits into
googleapis:mainfrom
yirutang:stuck-fix

Conversation

@yirutang

@yirutang yirutang commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes 1931

If you write sample code, please follow the samples format.

@yirutang yirutang requested review from a team and loferris January 13, 2023 17:54
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jan 13, 2023
@yirutang yirutang requested a review from GaoleMeng January 13, 2023 17:57
@yirutang yirutang requested a review from a team January 13, 2023 18:09
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yirutang yirutang requested a review from shollyman January 13, 2023 19:28
shollyman
shollyman reviewed Jan 13, 2023
View reviewed changes
Comment thread ...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java Outdated
Comment thread ...ud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/FakeBigQueryWrite.java
@yirutang yirutang added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 13, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@yirutang yirutang merged commit 2d648cf into googleapis:main Jan 13, 2023
@release-please release-please Bot mentioned this pull request Jan 18, 2023
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jan 18, 2023
@release-please
chore(main): release 2.28.2 (#1936)
53820c6 
🤖 I have created a release *beep* *boop*
---


## [2.28.2](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.28.1...v2.28.2) (2023-01-18)


### Bug Fixes

* Add a timeout on retry for retryable errors ([#1930](https://togithub.com/googleapis/java-bigquerystorage/issues/1930)) ([2d648cf](https://togithub.com/googleapis/java-bigquerystorage/commit/2d648cf9706a6e7bc155e8769ba7dda2a6bc3061))
* Add precision overwritten to 9 digit if the passed in JSON type is FLOAT or DOUBLE ([#1932](https://togithub.com/googleapis/java-bigquerystorage/issues/1932)) ([417bc6c](https://togithub.com/googleapis/java-bigquerystorage/commit/417bc6c76f7b9fa602721c3c183c487c5aab2e09))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.20.2 ([#1929](https://togithub.com/googleapis/java-bigquerystorage/issues/1929)) ([a95ae9d](https://togithub.com/googleapis/java-bigquerystorage/commit/a95ae9d708bd3e2d8f55297a6004a0d937c8d83f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris

@GaoleMeng GaoleMeng Awaiting requested review from GaoleMeng

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. kokoro:run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yirutang @shollyman @yoshi-kokoro