Skip to content

feat(storage): WithMeterProvider allows custom meter provider configuration#12668

Merged
cojenco merged 4 commits into
googleapis:mainfrom
cojenco:withmeter
Aug 26, 2025
Merged

feat(storage): WithMeterProvider allows custom meter provider configuration#12668
cojenco merged 4 commits into
googleapis:mainfrom
cojenco:withmeter

Conversation

@cojenco

@cojenco cojenco commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@cojenco cojenco requested review from a team August 6, 2025 23:15
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 6, 2025
@cojenco cojenco marked this pull request as draft August 6, 2025 23:19
@BrennaEpp BrennaEpp self-requested a review August 12, 2025 18:43
@cojenco cojenco marked this pull request as ready for review August 12, 2025 18:47

@BrennaEpp BrennaEpp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also test how the provider interacts with other configs?

Comment thread storage/grpc_metrics.go Outdated
Comment thread storage/internal/experimental.go
Co-authored-by: Brenna N Epp <brennanatashaepp@gmail.com>
@cojenco

cojenco commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

Should we also test how the provider interacts with other configs?

I could add more tests using multiple client options. There are more integration tests added in GCSFuse as well GoogleCloudPlatform/gcsfuse#3729

@cojenco cojenco requested a review from BrennaEpp August 25, 2025 23:50
@cojenco cojenco merged commit 7f574b0 into googleapis:main Aug 26, 2025
9 checks passed
gcf-merge-on-green Bot pushed a commit that referenced this pull request Sep 23, 2025
🤖 I have created a release *beep* *boop*
---


## [1.57.0](https://togithub.com/googleapis/google-cloud-go/compare/storage/v1.56.1...storage/v1.57.0) (2025-09-23)


### Features

* **storage/control:** Add new GetIamPolicy, SetIamPolicy, and TestIamPermissions RPCs ([d73f912](https://togithub.com/googleapis/google-cloud-go/commit/d73f9123be77bb3278f48d510cd0fb22feb605bc))
* **storage:** Post support dynamic key name ([#12677](https://togithub.com/googleapis/google-cloud-go/issues/12677)) ([9e761f9](https://togithub.com/googleapis/google-cloud-go/commit/9e761f961a2c4351b3e0793ed655314ac5853903))
* **storage:** WithMeterProvider allows custom meter provider configuration ([#12668](https://togithub.com/googleapis/google-cloud-go/issues/12668)) ([7f574b0](https://togithub.com/googleapis/google-cloud-go/commit/7f574b01e0b454c1ef5c13e6a58075e394ee990d))


### Bug Fixes

* **storage:** Free buffers in Bidi Reader ([#12839](https://togithub.com/googleapis/google-cloud-go/issues/12839)) ([bc247fd](https://togithub.com/googleapis/google-cloud-go/commit/bc247fdc3f5234a8bd6934e58d5b0b578f1335cb))
* **storage:** Make Writer thread-safe. ([#12753](https://togithub.com/googleapis/google-cloud-go/issues/12753)) ([9ea380b](https://togithub.com/googleapis/google-cloud-go/commit/9ea380bea5b980a9054d201be4f315a195da2182))
* **storage:** No progress report for oneshot write ([#12746](https://togithub.com/googleapis/google-cloud-go/issues/12746)) ([b97c286](https://togithub.com/googleapis/google-cloud-go/commit/b97c286ec369a10a81b1a8a3a1aae18b46d2dfbc))


### Performance Improvements

* **storage:** Pipeline gRPC writes ([#12422](https://togithub.com/googleapis/google-cloud-go/issues/12422)) ([1f2c5fe](https://togithub.com/googleapis/google-cloud-go/commit/1f2c5fe2843724302086fe04cb8dab8b515969c5))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants