fix(internal/aliasfix): handle import paths correctly#10097
Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom May 3, 2024
Merged
fix(internal/aliasfix): handle import paths correctly#10097gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
Conversation
The last component in import path of the old genproto path did not correspond to the import path -- usually.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
May 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.113.0](https://togithub.com/googleapis/google-cloud-go/compare/v0.112.2...v0.113.0) (2024-05-08) ### Features * **civil:** Add Compare method to Date, Time, and DateTime ([#10010](https://togithub.com/googleapis/google-cloud-go/issues/10010)) ([34455c1](https://togithub.com/googleapis/google-cloud-go/commit/34455c15d62b089f3281ff4c663245e72b257f37)) ### Bug Fixes * **all:** Bump x/net to v0.24.0 ([#10000](https://togithub.com/googleapis/google-cloud-go/issues/10000)) ([ba31ed5](https://togithub.com/googleapis/google-cloud-go/commit/ba31ed5fda2c9664f2e1cf972469295e63deb5b4)) * **debugger:** Add internaloption.WithDefaultEndpointTemplate ([3b41408](https://togithub.com/googleapis/google-cloud-go/commit/3b414084450a5764a0248756e95e13383a645f90)) * **internal/aliasfix:** Handle import paths correctly ([#10097](https://togithub.com/googleapis/google-cloud-go/issues/10097)) ([fafaf0d](https://togithub.com/googleapis/google-cloud-go/commit/fafaf0d0a293096559a4655ea61062cb896f1568)) * **rpcreplay:** Properly unmarshal dynamic message ([#9774](https://togithub.com/googleapis/google-cloud-go/issues/9774)) ([53ccb20](https://togithub.com/googleapis/google-cloud-go/commit/53ccb20d925ccb00f861958d9658b55738097dc6)), refs [#9773](https://togithub.com/googleapis/google-cloud-go/issues/9773) ### Documentation * **testing:** Switch deprecated WithInsecure to WithTransportCredentials ([#10091](https://togithub.com/googleapis/google-cloud-go/issues/10091)) ([2b576ab](https://togithub.com/googleapis/google-cloud-go/commit/2b576abd1c3bfca2f962de0e024524f72d3652c0)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last component in import path of the old genproto path does not correspond to the import path -- usually.
The import paths usually look like
google.golang.org/genproto/googleapis/analytics/admin/v1alpha, however the imported package name isadmin. This uses a heuristic to detect whether the last path component is a version,There are some packages that do not fit that description though, e.g.
google.golang.org/genproto/googleapis/devtools/containeranalysis/v1beta1/grafeas.