Skip to content

Support options for GetCodeownersErrors#2953

Merged
gmlewis merged 3 commits intogoogle:masterfrom
lachlancooper:add-codeowners-options
Oct 10, 2023
Merged

Support options for GetCodeownersErrors#2953
gmlewis merged 3 commits intogoogle:masterfrom
lachlancooper:add-codeowners-options

Conversation

@lachlancooper
Copy link
Copy Markdown
Contributor

@lachlancooper lachlancooper commented Oct 9, 2023 •
edited
Loading

Fixes #2952

@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lachlancooper lachlancooper marked this pull request as ready for review October 9, 2023 04:01
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #2953 (0b6bb05) into master (74db58f) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 0b6bb05 differs from pull request most recent head 456ef85. Consider uploading reports for the commit 456ef85 to get more accurate results

@@           Coverage Diff           @@
##           master    #2953   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         145      145           
  Lines       12767    12771    +4     
=======================================
+ Hits        12534    12538    +4     
  Misses        158      158           
  Partials       75       75
Files Coverage Δ
github/repos_codeowners.go 100.00% <100.00%> (ø)

gmlewis
gmlewis requested changes Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lachlancooper !

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Oct 9, 2023
@lachlancooper lachlancooper requested a review from gmlewis October 9, 2023 21:23
gmlewis
gmlewis approved these changes Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lachlancooper !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@exageraldo
Copy link
Copy Markdown
Contributor

exageraldo commented Oct 10, 2023

LGTM 👍🏻

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Oct 10, 2023

Thank you, @exageraldo !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 10, 2023
@gmlewis gmlewis merged commit fb8f20f into google:master Oct 10, 2023
@gmlewis gmlewis mentioned this pull request Oct 11, 2023
Merged
@lachlancooper lachlancooper deleted the add-codeowners-options branch October 17, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@exageraldo exageraldo exageraldo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting ref parameter for GetCodeownersErrors

3 participants

@lachlancooper @exageraldo @gmlewis